Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented generic kv-pair setting of export_config from args #6978

Closed
wants to merge 5 commits into from

Conversation

borisfom
Copy link
Collaborator

@borisfom borisfom commented Jul 5, 2023

What does this PR do ?

This will be a basis for several export extensions that involve user input.
As an example, I have changed handling of --cache_support arg in export.py to use the new method.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
@borisfom borisfom requested a review from VahidooX July 5, 2023 17:52
@github-actions github-actions bot added core Changes to NeMo Core ASR labels Jul 5, 2023
@borisfom borisfom requested a review from titu1994 July 5, 2023 17:52
@borisfom borisfom changed the base branch from main to r1.20.0 July 5, 2023 18:16
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, minor changes required

nemo/collections/asr/models/asr_model.py Show resolved Hide resolved
nemo/core/classes/exportable.py Show resolved Hide resolved
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
@borisfom borisfom requested a review from titu1994 July 6, 2023 00:39
@borisfom borisfom mentioned this pull request Jul 6, 2023
Copy link
Collaborator

@VahidooX VahidooX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would you please just add some documentation on how to export hybrid and cache-aware models to here:
https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/main/core/export.html

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks !

nemo/collections/asr/models/asr_model.py Show resolved Hide resolved
@borisfom
Copy link
Collaborator Author

borisfom commented Jul 6, 2023

Superseded by #6983

@borisfom borisfom closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR core Changes to NeMo Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants