Add the strategy argument to MegatronGPTModel.generate()
#7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odelalleau
force-pushed
the
od/strategy-args
branch
2 times, most recently
from
43681ae to
87d2d9c
Compare
odelalleau
changed the title
strategy_args argument to MegatronGPTModel.generate()strategy argument to MegatronGPTModel.generate()
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
odelalleau
force-pushed
the
od/strategy-args
branch
from
87d2d9c to
705363f
Compare
It is passed as an explicit argument rather than through `**strategy_args` so as to ensure someone cannot accidentally pass other arguments that would end up being ignored. It is a keyword-only argument to ensure that if in the future we want to update the signature to `**strategy_args`, we can do it without breaking code. Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com>
odelalleau
force-pushed
the
od/strategy-args
branch
from
705363f to
4e57863
Compare
|
Regarding the CodeQL error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The motivation is to be able to override the text generation strategy when calling
MegatronGPTModel.generate().It is passed as an explicit argument rather than through
**strategy_argsso as to ensure someone cannot accidentally pass other arguments that would end up being ignored.It is a keyword-only argument to ensure that if in the future we want to update the signature to
**strategy_args, we can do it without breaking code.Collection: nlp
Changelog
strategyargument toMegatronGPTModel.generate()Before your PR is "Ready for review"
Pre checks:
PR Type:
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.