Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix partial transcribe #7284

Merged
merged 4 commits into from
Aug 22, 2023
Merged

fix partial transcribe #7284

merged 4 commits into from
Aug 22, 2023

Conversation

stevehuang52
Copy link
Collaborator

What does this PR do ?

Modify partial transcribe to support return_hypotheses=False to save memory.

Collection: [ASR]

Signed-off-by: stevehuang52 <heh@nvidia.com>
@stevehuang52 stevehuang52 requested a review from fayejf August 21, 2023 17:36
@github-actions github-actions bot added the ASR label Aug 21, 2023
@stevehuang52 stevehuang52 requested a review from titu1994 August 21, 2023 17:41
Signed-off-by: stevehuang52 <heh@nvidia.com>
@stevehuang52 stevehuang52 requested a review from rlangman August 22, 2023 14:27
@stevehuang52 stevehuang52 merged commit 5ea9475 into main Aug 22, 2023
@stevehuang52 stevehuang52 deleted the fix_partial_transcribe branch August 22, 2023 18:38
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
* fix partial transcribe

Signed-off-by: stevehuang52 <heh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* refactor

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: dorotat <dorotat@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* fix partial transcribe

Signed-off-by: stevehuang52 <heh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* refactor

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants