-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTS] Fix audio codec type checks #7373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are they no test cases for Codecs yet? |
There are only a few. We haven't added CI tests which run the recipe itself, and I could not think of many tests that were not effectively just asserting what the neural typechecking is supposed to validate automatically at runtime in terms of types/dimensions of each module (though clearly it wasn't being validated). |
Type checks work if the entire pipeline of types is setup - including data loader and loss. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3402183
to
53e12b7
Compare
Signed-off-by: Ryan <rlangman@nvidia.com>
Signed-off-by: Ryan <rlangman@nvidia.com>
53e12b7
to
97ee70f
Compare
What does this PR do ?
Most classes in the audio codec code had input_type() and output_type() parameters but were missing the typecheck() annotation on the forward() method to enforce them.
This commit adds the typecheck() to all relevant forward() methods and fixes their corresponding type annotations.
Also has a small change to add the vector quantizer parameters to the optimizer in the model (though the existing RVQ has no trainable parameters).
Collection: [TTS]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: