Fix errors caused by different dimensionality in get_dist function #7490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Abhishree <abhishreetm@gmail.com> Co-authored-by: Eric Harper <complex451@gmail.com>
…#7454) Signed-off-by: Abhishree <abhishreetm@gmail.com>
* new frame_confidence and alignments lists are now always created after the while loop Signed-off-by: Aleksandr Laptev <alaptev@nvidia.com> * tests added Signed-off-by: Aleksandr Laptev <alaptev@nvidia.com> --------- Signed-off-by: Aleksandr Laptev <alaptev@nvidia.com> (cherry picked from commit 6012ca2)
Signed-off-by: Nithin Rao Koluguri <nithinraok> Co-authored-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com> Co-authored-by: Hongbin Liu <hongbinl@nvidia.com>
|
this is a bugfix for r1.21.0. Please change the base. |
Signed-off-by: Xuesong Yang <16880-xueyang@users.noreply.gitlab-master.nvidia.com> Co-authored-by: Xuesong Yang <16880-xueyang@users.noreply.gitlab-master.nvidia.com>
That was unintentional. I would change it back to have the squeeze(1) in get_dist. Thanks for finding that. |
* add sleep Signed-off-by: Gerald Shen <geshen@nvidia.com> * add sleep onto config instead Signed-off-by: Gerald Shen <geshen@nvidia.com> * add comment Signed-off-by: Gerald Shen <geshen@nvidia.com> --------- Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
redoctopus
force-pushed
the
tts_tutorial_fix
branch
from
b5483a1 to
3206aeb
Compare
Gotcha, will open a new PR with this fix (and on top of |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The TTS Aligner's
get_dist()now has an extra dimension (from PR #6806); this PR fixes errors stemming from this in the Aligner notebook.@rlangman -- was the change from returning a (B, C, T)-dimensional tensor to a (B, 1, C, T)-dimensional one intentional? Do we want to keep that or change it back by adding a squeeze(1)?
Collection: TTS
PR Type: