Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics for SE tutorial #7604

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

anteju
Copy link
Collaborator

@anteju anteju commented Oct 2, 2023

What does this PR do ?

This PR fixes a bug in SE tutorial caused by initialization of metrics for audio-to-audio models.

Collection: ASR, Tutorials

Changelog

  • Updated metric initialization
  • Small fixes in the tutorial notebook

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@anteju anteju requested a review from nithinraok October 2, 2023 22:29
@github-actions github-actions bot added the ASR label Oct 2, 2023
Signed-off-by: Ante Jukić <ajukic@nvidia.com>
@anteju anteju force-pushed the pr/fix-se-tutorial-r1.21 branch from 12e0310 to 2afb959 Compare October 2, 2023 23:15
Copy link
Collaborator

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nithinraok nithinraok merged commit 8620bb0 into NVIDIA:r1.21.0 Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants