Set RotaryEmbedding base frequency from config
#7734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>
for more information, see https://pre-commit.ci
nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py
Outdated
Show resolved
Hide resolved
titu1994
reviewed
Oct 16, 2023
nemo/collections/nlp/models/language_modeling/megatron/gpt_model.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>
burchim
pushed a commit
to burchim/NeMo
that referenced
this pull request
Oct 28, 2023
* set rope base frequency from model config Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rename base to rotary_base Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> --------- Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: maxime burchi <maxime.burchi@gmail.com>
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
* set rope base frequency from model config Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rename base to rotary_base Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> --------- Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* set rope base frequency from model config Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rename base to rotary_base Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> --------- Signed-off-by: Shantanu Acharya <shantanua@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the ability to change the base value of RoPE embeddings from config.
Collection: nlp