Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add All Multimodal Source Code #7791

Merged
merged 508 commits into from
Dec 13, 2023

Merge branch 'main' into multimodal/merge_mm_code

373ef57
Select commit
Loading
Failed to load commit list.
Merged

Add All Multimodal Source Code #7791

Merge branch 'main' into multimodal/merge_mm_code
373ef57
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Dec 12, 2023 in 5s

10 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 9 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 14 in nemo/collections/multimodal/losses/clip_loss.py

See this annotation in the file changed.

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note

Module 'torch' is imported with both 'import' and 'import from'.

Check notice on line 53 in examples/multimodal/convert_ckpt_to_nemo.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused global variable Note

The global variable 'HAVE_MEGATRON_CORE' is not used.

Check notice on line 57 in nemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py

See this annotation in the file changed.

Code scanning / CodeQL

Cyclic import Note

Import of module
nemo.collections.nlp.modules.common.text_generation_utils
Loading
begins an import cycle.

Check notice on line 625 in nemo/collections/nlp/modules/common/text_generation_strategy.py

See this annotation in the file changed.

Code scanning / CodeQL

Cyclic import Note

Import of module
nemo.collections.multimodal.models.multimodal_llm.neva.neva_model
Loading
begins an import cycle.

Check notice on line 968 in nemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 754 in nemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 248 in examples/multimodal/multimodal_llm/neva/neva_evaluation.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check notice on line 252 in examples/multimodal/multimodal_llm/neva/neva_evaluation.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check notice on line 574 in nemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check failure on line 193 in nemo/collections/multimodal/data/common/webdataset.py

See this annotation in the file changed.

Code scanning / CodeQL

Wrong name for an argument in a class instantiation Error

Keyword argument 'epoch' is not a supported parameter name of
detshuffle2.__init__
Loading
.
Keyword argument 'bufsize' is not a supported parameter name of
detshuffle2.__init__
Loading
.

Check warning on line 133 in nemo/collections/multimodal/data/common/webdataset_s3.py

See this annotation in the file changed.

Code scanning / CodeQL

File is not always closed Warning

File is opened but is not closed.