Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NLP] Use helpers from utils_funcs.py in Llama conversion #7979

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[NLP] Use helpers from utils_funcs.py in Llama conversion #7979

merged 1 commit into from
Dec 7, 2023

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Dec 6, 2023

What does this PR do ?

An improvement to use torch_dtype_from_precision helper to resolve precision.

Collection: [NLP]

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • Improvement

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@janekl
Resolve dtype with utils_funcs.py
e4c89ef 
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@github-actions github-actions bot added the NLP label Dec 6, 2023
@janekl janekl mentioned this pull request Dec 6, 2023
Closed
8 tasks
ericharper
ericharper approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 5103a9a into main Dec 7, 2023
15 checks passed
@ericharper ericharper deleted the jlasek/resolving_dtype branch December 7, 2023 20:58
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
@janekl @pzelasko
Resolve dtype with utils_funcs.py (NVIDIA#7979)
fa0c659 
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
@janekl @sashameister
Resolve dtype with utils_funcs.py (NVIDIA#7979)
fe95314 
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@janekl
Resolve dtype with utils_funcs.py (NVIDIA#7979)
d8187a5 
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

Assignees
No one assigned
Labels
NLP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janekl @ericharper