[NLP] ArtifactItem with init=True to make it debuggable #7980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janekl
changed the title
8 tasks
titu1994
reviewed
Dec 6, 2023
| @@ -359,8 +359,6 @@ def register_artifact(self, model, config_path: str, src: str, verify_src_exists | |||
| """ | |||
| app_state = AppState() | |||
|
|
|||
| artifact_item = model_utils.ArtifactItem() | |||
There was a problem hiding this comment.
How about keeping the instantiation here, with dummy default values of "" and type of local by default ? Then the remainder of the code doesn't need to be changed
There was a problem hiding this comment.
Good suggestion, adopted it. Now changes boil down to removing init=False and setting dummy defaults
janekl
force-pushed
the
jlasek/artifact_item_printable
branch
from
f9b5a68
to
e53a491
Compare
|
jenkins |
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
janekl
force-pushed
the
jlasek/artifact_item_printable
branch
from
e53a491
to
1a389bf
Compare
Thanks! I've just rebased it, I'll merge once pipeline completes. |
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
* ArtifactItem with init=True to make it debuggable Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Initialize ArtifactItem with dummy values to keep changes minimal Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* ArtifactItem with init=True to make it debuggable Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Initialize ArtifactItem with dummy values to keep changes minimal Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* ArtifactItem with init=True to make it debuggable Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Initialize ArtifactItem with dummy values to keep changes minimal Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
When debugging artifact items I struggled with
ArtifactItemas it is defined withinit=Falsewhich results in issues when printing an instance of this class.The following minimal example illustrates the problem - this code
results in AttributeError: 'Point' object has no attribute 'x'. So it doesn't make it easier to check what's going on.
Collection: [NLP]
Jenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information