fix device setting to allow using accelerator cpu #8084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oren Amsalem <oren.a4@gmail.com>
for more information, see https://pre-commit.ci
titu1994
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Makes sense, thanks for the fix ! @tbartley94 for final review
|
jenkins |
|
jenkins |
|
@titu1994 i know you pushed but just for record I'm not seeing any issues so review is approved |
|
Oh thanks for the update, I think I misremembered as this having your approval on slack somehow, turns out it was a different topic different pr. Sorry about that. |
|
do you @titu1994 or @tbartley94 have any idea about this one: |
|
Hmm, lemme take a look. I'd wager it's some tech debt between PTL versions. (fervor for wav2vec dipped before PTL 2.0 was released, so the code is likely working off a dated namespace.) |
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
* fix device setting to allow using accelerator cpu Signed-off-by: Oren Amsalem <oren.a4@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Oren Amsalem <oren.a4@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* fix device setting to allow using accelerator cpu Signed-off-by: Oren Amsalem <oren.a4@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Oren Amsalem <oren.a4@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* fix device setting to allow using accelerator cpu Signed-off-by: Oren Amsalem <oren.a4@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Oren Amsalem <oren.a4@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
It is currently impossible to run wav2vec with
trainer.accelerator=cpuif the machine has a gpu.The padding_mask is already on the device set in
trainer.acceleratorbut if the machine has a GPU the DEVICE variable will contain cuda and this error message will be received:PR Type:
Additional Information
@titu1994, @redoctopus, @jbalam-nv, or @okuchaiev