Token count and sequence length logging for MegatronGPTSFTModel #8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vysarge
force-pushed
the
vsarge/seqlen_logging
branch
from
3727d60 to
fe2070e
Compare
vysarge
changed the title
|
@cuichenx / @ericharper can you review? |
|
jenkins |
|
jenkins |
…s a config option Signed-off-by: Valerie Sarge <vsarge@nvidia.com>
vysarge
force-pushed
the
vsarge/seqlen_logging
branch
from
f240597 to
4e838c3
Compare
|
jenkins |
ppisljar
pushed a commit
to ppisljar/NeMo
that referenced
this pull request
Jan 16, 2024
…s a config option (NVIDIA#8136) Signed-off-by: Valerie Sarge <vsarge@nvidia.com> Signed-off-by: ppisljar <peter.pisljar@gmail.com>
minitu
pushed a commit
to minitu/NeMo
that referenced
this pull request
Jan 19, 2024
…s a config option (NVIDIA#8136) Signed-off-by: Valerie Sarge <vsarge@nvidia.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
…s a config option (NVIDIA#8136) Signed-off-by: Valerie Sarge <vsarge@nvidia.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
…s a config option (#8136) Signed-off-by: Valerie Sarge <vsarge@nvidia.com> Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…s a config option (NVIDIA#8136) Signed-off-by: Valerie Sarge <vsarge@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds an option to enable progress bar logging for sequence length (including padding tokens) and real token count for each train step with MegatronGPTSFTModel to enable accurate calculation of tokens/sec and related metrics.
Collection: nlp/language_modeling
Changelog
Usage
Jenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.