Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer_norm_1p Apex call to match Apex API #8142

Closed

Conversation

ShriyaPalsamudram
Copy link
Collaborator

@ShriyaPalsamudram ShriyaPalsamudram commented Jan 9, 2024

What does this PR do ?

Apex _fast_layer_norm expects required memory_efficient parameter to be passed when it is called: https://github.com/NVIDIA/apex/blob/master/apex/contrib/layer_norm/layer_norm.py#L37

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jan 9, 2024
@ShriyaPalsamudram ShriyaPalsamudram marked this pull request as ready for review January 9, 2024 21:28
Signed-off-by: Shriya Palsamudram <spalsamudram@nvidia.com>
@jbaczek
Copy link
Collaborator

jbaczek commented Jan 10, 2024

This is a duplicate: #8129

@ShriyaPalsamudram ShriyaPalsamudram deleted the shriya/fix_layer_norm branch January 10, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants