Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add first_val_step to mcore scheduler #8150

Merged
merged 11 commits into from
Jan 25, 2024
Merged

add first_val_step to mcore scheduler #8150

merged 11 commits into from
Jan 25, 2024

Conversation

JimmyZhang12
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jan 10, 2024
@JimmyZhang12 JimmyZhang12 force-pushed the jiemingz/first_val_step branch from 50a8f2c to 2e280bc Compare January 11, 2024 01:13
@jiemingz
add first_val_step for mcore schedules
a345be3 
Signed-off-by: jiemingz <jiemingz@nvidia.com>
@JimmyZhang12 JimmyZhang12 force-pushed the jiemingz/first_val_step branch from 2e280bc to a345be3 Compare January 11, 2024 01:14
jiemingz and others added 2 commits January 10, 2024 20:29
@jiemingz
fix if non fp8
d25f22f 
Signed-off-by: jiemingz <jiemingz@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d4b1fa8 
for more information, see https://pre-commit.ci
@erhoo82 erhoo82 self-requested a review January 11, 2024 07:03
erhoo82
erhoo82 previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@erhoo82 erhoo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erhoo82
Copy link
Collaborator

erhoo82 commented Jan 11, 2024

jenkins

@erhoo82
Copy link
Collaborator

erhoo82 commented Jan 11, 2024

@ericharper @athitten
Can you help review this PR?

@ericharper
Copy link
Collaborator

jenkins

@jiemingz
add mcore installation to ci
9da045a 
Signed-off-by: jiemingz <jiemingz@nvidia.com>
@github-actions github-actions bot added the CI label Jan 23, 2024
@JimmyZhang12
Copy link
Contributor Author

jenkins

@ericharper
Copy link
Collaborator

jenkins

@JimmyZhang12
Update Jenkinsfile
decd0f8 
Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
@JimmyZhang12
Copy link
Contributor Author

jenkins

2 similar comments
@ericharper
Copy link
Collaborator

jenkins

@JimmyZhang12
Copy link
Contributor Author

jenkins

@ericharper
Copy link
Collaborator

jenkins

jiemingz and others added 2 commits January 24, 2024 13:49
@ericharper
Copy link
Collaborator

jenkins

@ericharper
Copy link
Collaborator

jenkins

ericharper
ericharper approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit f25be00 into NVIDIA:main Jan 25, 2024
11 checks passed
yaoyu-33 pushed a commit that referenced this pull request Jan 31, 2024
@JimmyZhang12 @jiemingz
@pre-commit-ci @ericharper @yaoyu-33
add first_val_step to mcore scheduler (#8150)
47b0126 
* add first_val_step for mcore schedules

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* fix if non fp8

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add mcore installation to ci

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* Update Jenkinsfile

Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>

* Fix SFT missing arg

Signed-off-by: jiemingz <jiemingz@nvidia.com>

---------

Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: jiemingz <jiemingz@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
stevehuang52 pushed a commit that referenced this pull request Jan 31, 2024
@JimmyZhang12 @jiemingz
@pre-commit-ci @ericharper @stevehuang52
add first_val_step to mcore scheduler (#8150)
c310bcc 
* add first_val_step for mcore schedules

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* fix if non fp8

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add mcore installation to ci

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* Update Jenkinsfile

Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>

* Fix SFT missing arg

Signed-off-by: jiemingz <jiemingz@nvidia.com>

---------

Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: jiemingz <jiemingz@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
layalir pushed a commit to layalir/NeMo that referenced this pull request Jan 31, 2024
@JimmyZhang12 @jiemingz
@pre-commit-ci @ericharper @layalir
add first_val_step to mcore scheduler (NVIDIA#8150)
a2d68f8 
* add first_val_step for mcore schedules

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* fix if non fp8

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add mcore installation to ci

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* Update Jenkinsfile

Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>

* Fix SFT missing arg

Signed-off-by: jiemingz <jiemingz@nvidia.com>

---------

Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: jiemingz <jiemingz@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
@JimmyZhang12 @jiemingz
@pre-commit-ci @ericharper @sashameister
add first_val_step to mcore scheduler (NVIDIA#8150)
94e1688 
* add first_val_step for mcore schedules

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* fix if non fp8

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add mcore installation to ci

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* Update Jenkinsfile

Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>

* Fix SFT missing arg

Signed-off-by: jiemingz <jiemingz@nvidia.com>

---------

Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: jiemingz <jiemingz@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Signed-off-by: Sasha Meister <ameister@nvidia.com>
layalir added a commit to layalir/NeMo that referenced this pull request Feb 29, 2024
@layalir
Revert "add first_val_step to mcore scheduler (NVIDIA#8150)"
43ae7f3 
This reverts commit f25be00.
minitu pushed a commit to minitu/NeMo that referenced this pull request Mar 7, 2024
@JimmyZhang12 @jiemingz
@pre-commit-ci @ericharper
add first_val_step to mcore scheduler (NVIDIA#8150)
86460b8 
* add first_val_step for mcore schedules

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* fix if non fp8

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add mcore installation to ci

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* Update Jenkinsfile

Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>

* Fix SFT missing arg

Signed-off-by: jiemingz <jiemingz@nvidia.com>

---------

Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: jiemingz <jiemingz@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
pablo-garay pushed a commit that referenced this pull request Mar 19, 2024
@JimmyZhang12 @jiemingz
@pre-commit-ci @ericharper @pablo-garay
add first_val_step to mcore scheduler (#8150)
ef5a2db 
* add first_val_step for mcore schedules

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* fix if non fp8

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add mcore installation to ci

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* Update Jenkinsfile

Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>

* Fix SFT missing arg

Signed-off-by: jiemingz <jiemingz@nvidia.com>

---------

Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: jiemingz <jiemingz@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@JimmyZhang12 @jiemingz
@pre-commit-ci @ericharper
add first_val_step to mcore scheduler (NVIDIA#8150)
fa59574 
* add first_val_step for mcore schedules

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* fix if non fp8

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add mcore installation to ci

Signed-off-by: jiemingz <jiemingz@nvidia.com>

* Update Jenkinsfile

Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>

* Fix SFT missing arg

Signed-off-by: jiemingz <jiemingz@nvidia.com>

---------

Signed-off-by: jiemingz <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: jiemingz <jiemingz@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

@erhoo82 erhoo82 erhoo82 left review comments

@athitten athitten Awaiting requested review from athitten

Assignees
No one assigned
Labels
CI NLP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JimmyZhang12 @erhoo82 @ericharper @jiemingz