Revert "adding OnlineSampleMapping" #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablo-garay
requested review from
michalivne,
ericharper,
arendu,
bmwshop and
yzhang123
and removed request for
michalivne,
ericharper,
arendu,
bmwshop and
yzhang123
|
jenkins |
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
pablo-garay
force-pushed
the
revert-8137-adithyare/OnlineSampleMapping
branch
from
91d5685 to
301c326
Compare
|
Is there a CI test which uses context parallel? @pablo-garay @ericharper |
|
jenkins |
|
@xrennvidia yes but w/o CI its hard to debug/iterate on the PR. |
|
jenkins |
minitu
pushed a commit
to minitu/NeMo
that referenced
this pull request
Jan 19, 2024
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Pablo Garay <pagaray@nvidia.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
pablo-garay
added a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8137
Nemo pipeline is broken (finetune tests failing) due to this. Hence revert.
More context/details:
10:43
Above problematic PR was merged after my context parallelism PR. So for sanity check, I also ran a pipeline with the NeMo commit ID of context parallelism merging (i.e., without above problematic PR)
you can see those two fine-tuning test passed, so I think context parallelism code works fine