Add the interface to use SHARP to FSDP strategy #8202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sangkug Lym <slym@nvidia.com>
|
jenkins |
dimapihtar
approved these changes
Jan 19, 2024
|
jenkins |
akoumpa
pushed a commit
to akoumpa/NeMo
that referenced
this pull request
Jan 20, 2024
Signed-off-by: Sangkug Lym <slym@nvidia.com>
stevehuang52
pushed a commit
that referenced
this pull request
Jan 31, 2024
Signed-off-by: Sangkug Lym <slym@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Sangkug Lym <slym@nvidia.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Sangkug Lym <slym@nvidia.com> Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
Signed-off-by: Sangkug Lym <slym@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add the SHARP argument interface to FSDP strategy.
SHARP here applies to the data-parallel process group.
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information