Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k2 version #8478

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Update k2 version #8478

merged 1 commit into from
Feb 23, 2024

Conversation

artbataev
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev artbataev requested a review from GNroy February 21, 2024 21:07
@artbataev artbataev marked this pull request as draft February 21, 2024 21:24
@artbataev
Copy link
Collaborator Author

jenkins

@artbataev artbataev marked this pull request as ready for review February 22, 2024 16:32
@artbataev
Copy link
Collaborator Author

jenkins

@artbataev
Copy link
Collaborator Author

artbataev commented Feb 23, 2024

@GNroy FYI: I am able to build a container from nvcr.io/nvidia/pytorch:23.09-py3 using this commit, but nvcr.io/nvidia/pytorch:23.10-py3 and higher fails.
Locally I can install k2 with pytorch 2.2 (compiled with Cuda 12.1)

@artbataev artbataev merged commit 4f3e39f into main Feb 23, 2024
15 checks passed
@artbataev artbataev deleted the update_k2 branch February 23, 2024 08:07
@artbataev artbataev mentioned this pull request Feb 23, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants