Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PEFT doc #8664

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Update PEFT doc #8664

merged 2 commits into from
Mar 16, 2024

Conversation

cuichenx
Copy link
Collaborator

@cuichenx cuichenx commented Mar 15, 2024

What does this PR do ?

Update PEFT doc

Collection: [Note which collection this PR will affect]

Changelog

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Chen Cui <chcui@nvidia.com>
@github-actions github-actions bot added the NLP label Mar 15, 2024
Signed-off-by: Chen Cui <chcui@nvidia.com>
@ericharper ericharper merged commit 7010f93 into main Mar 16, 2024
12 checks passed
@ericharper ericharper deleted the chcui/doc_lora branch March 16, 2024 05:20
pablo-garay pushed a commit that referenced this pull request Mar 19, 2024
* update PEFT doc

Signed-off-by: Chen Cui <chcui@nvidia.com>

* update support matrix

Signed-off-by: Chen Cui <chcui@nvidia.com>

---------

Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* update PEFT doc

Signed-off-by: Chen Cui <chcui@nvidia.com>

* update support matrix

Signed-off-by: Chen Cui <chcui@nvidia.com>

---------

Signed-off-by: Chen Cui <chcui@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants