Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model quantization manual #8730

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Model quantization manual #8730

merged 4 commits into from
Apr 1, 2024

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Mar 22, 2024

What does this PR do ?

Documentation for model quantization using AMMO.

Collection: NLP

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

@github-actions github-actions bot added the NLP label Mar 22, 2024
ericharper
ericharper previously approved these changes Mar 22, 2024
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl force-pushed the jlasek/ammo_quantization_docs branch from 6f1c0d1 to 9b084aa Compare March 25, 2024 16:43
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 35c040a into main Apr 1, 2024
128 checks passed
@ericharper ericharper deleted the jlasek/ammo_quantization_docs branch April 1, 2024 22:53
michal2409 pushed a commit that referenced this pull request Apr 3, 2024
* Model quantization manual

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Next iteration

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Use torch get_rank() for broader coverage of use-cases

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove unused import

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Michal Futrega <mfutrega@nvidia.com>
@janekl janekl mentioned this pull request Apr 3, 2024
8 tasks
mwawrzos pushed a commit that referenced this pull request Apr 4, 2024
* Model quantization manual

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Next iteration

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Use torch get_rank() for broader coverage of use-cases

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove unused import

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Model quantization manual

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Next iteration

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Use torch get_rank() for broader coverage of use-cases

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove unused import

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants