Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open source export and deploy modules #8743
Open source export and deploy modules #8743
Changes from 13 commits
9926619
e86e60e
62c6cdd
ef938b2
2747fbe
300c780
cc8f98f
6da56a6
0e11a3d
083f901
680ebee
f22e9e0
648acb6
fb27b4e
15effc8
75d57b8
c495af5
07e34c8
4217047
541838d
fd7a99c
310dc49
9f8ef15
b201bf5
56fd156
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice
Code scanning / CodeQL
Empty except Note
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
Check notice
Code scanning / CodeQL
Empty except Note
Check notice
Code scanning / CodeQL
Empty except Note
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The classname has insufficient context. Deploy Pytriton with which model? We are planning to deploy pytriton for streaming asr and tts too as new tools, so please call this class
DeployPytritonLLM
or something that denotes what it is deploying.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need for a specific model. The goal is to support the deployment of any model. You can either pass a nemo ckpt using this param
checkpoint_path
or in memory model using thismodel
param. The in memory model support will be added fully later though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so you're saying the same code for streaming will apply to both LLM and ASR? Then no need to act on this comment, but let's keep it un resolved so ASR team can look into it later
Check notice
Code scanning / CodeQL
Empty except Note
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note