-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NeMo dev doc restructure #8896
NeMo dev doc restructure #8896
Conversation
# Conflicts: # docs/source/collections/tts/data/ngc_models_codec.csv
@@ -80,67 +163,19 @@ Once you have :ref:`installed NeMo <installation>`, then you can run the code be | |||
import soundfile as sf | |||
sf.write("output_audio.wav", audio.to('cpu').detach().numpy()[0], 22050) | |||
|
|||
You can learn more by about specific tasks you are interested in by checking out the NeMo :doc:`tutorials <./tutorials>`, or documentation (e.g. read :doc:`here <../asr/intro>` to learn more about ASR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this sentence: "You can learn . . ." to "To learn more about specific tasks that interest you, check out the NeMo :doc:tutorials <./tutorials>
or documentation (for example, read :doc:here <../asr/intro>
to learn more about ASR).
@@ -80,67 +163,19 @@ Once you have :ref:`installed NeMo <installation>`, then you can run the code be | |||
import soundfile as sf | |||
sf.write("output_audio.wav", audio.to('cpu').detach().numpy()[0], 22050) | |||
|
|||
You can learn more by about specific tasks you are interested in by checking out the NeMo :doc:`tutorials <./tutorials>`, or documentation (e.g. read :doc:`here <../asr/intro>` to learn more about ASR). | |||
|
|||
You can also learn more about NeMo in the `NeMo Primer <https://github.com/NVIDIA/NeMo/blob/stable/tutorials/00_NeMo_Primer.ipynb>`_ tutorial, which introduces NeMo, PyTorch Lightning, and OmegaConf, and shows how to use, modify, save, and restore NeMo models. Additionally, the `NeMo Models <https://github.com/NVIDIA/NeMo/blob/stable/tutorials/01_NeMo_Models.ipynb>`__ tutorial explains the fundamentals of how NeMo models are created. These concepts are also explained in detail in the :doc:`NeMo Core <../core/core>` documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this sentence: "You can also learn more about" to "You can also learn more about NeMo in the NeMo Primer <https://github.com/NVIDIA/NeMo/blob/stable/tutorials/00_NeMo_Primer.ipynb>
_ tutorial, which introduces NeMo, PyTorch Lightning, and OmegaConf. It also shows how to use, modify, save, and restore NeMo models.
You can also learn more about NeMo in the `NeMo Primer <https://github.com/NVIDIA/NeMo/blob/stable/tutorials/00_NeMo_Primer.ipynb>`_ tutorial, which introduces NeMo, PyTorch Lightning, and OmegaConf, and shows how to use, modify, save, and restore NeMo models. Additionally, the `NeMo Models <https://github.com/NVIDIA/NeMo/blob/stable/tutorials/01_NeMo_Models.ipynb>`__ tutorial explains the fundamentals of how NeMo models are created. These concepts are also explained in detail in the :doc:`NeMo Core <../core/core>` documentation. | ||
|
||
|
||
Introductory videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to Introductory Videos
Introductory videos | ||
------------------- | ||
|
||
See the two introductory videos below for a high level overview of NeMo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the sentence: "See the two introductory videos below for a high level overview of NeMo." to "For a high level overview of NeMo, refer to the two introductory videos below." BTW, where are the links?
Installation | ||
------------ | ||
|
||
The simplest way to install NeMo is via pip, see info below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this sentence: "The simplest way to install NeMo is via pip, see info below. " to "The easiest method for installing NeMo is via pip. Refer to the details below.
conda create --name nemo python==3.10.12 | ||
conda activate nemo | ||
|
||
Install PyTorch using their `configurator <https://pytorch.org/get-started/locally/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this sentence: "Install PyTorch using their configurator <https://pytorch.org/get-started/locally/>
_." to "To install PyTorch, follow the instructions provided by the PyTorch configurator."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyedited content and rewrote some sentences for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* Update intro and why nemo in dev doc * Categorize tutorials * Update tutorials link * update index * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Update flash attention * Update flash attention * Fix few structure issue * Fix migration * Fix structure * Fix structure * Few updates * Add few more scripts * Fix scripts * Fix few things * Fix tutorial table * Restructure * Rename * Few fixes and moves * Move sections * Fix bib * Refactor files * Fixes * Fix * Fix few issues * remove scripts * Update docs --------- Co-authored-by: Pablo Garay <palenq@gmail.com>
* Update intro and why nemo in dev doc * Categorize tutorials * Update tutorials link * update index * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Update flash attention * Update flash attention * Fix few structure issue * Fix migration * Fix structure * Fix structure * Few updates * Add few more scripts * Fix scripts * Fix few things * Fix tutorial table * Restructure * Rename * Few fixes and moves * Move sections * Fix bib * Refactor files * Fixes * Fix * Fix few issues * remove scripts * Update docs --------- Co-authored-by: Pablo Garay <palenq@gmail.com>
* Update intro and why nemo in dev doc * Categorize tutorials * Update tutorials link * update index * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Update flash attention * Update flash attention * Fix few structure issue * Fix migration * Fix structure * Fix structure * Few updates * Add few more scripts * Fix scripts * Fix few things * Fix tutorial table * Restructure * Rename * Few fixes and moves * Move sections * Fix bib * Refactor files * Fixes * Fix * Fix few issues * remove scripts * Update docs --------- Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Ao Tang <aot@nvidia.com>
* Update intro and why nemo in dev doc * Categorize tutorials * Update tutorials link * update index * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Restructure * Update flash attention * Update flash attention * Fix few structure issue * Fix migration * Fix structure * Fix structure * Few updates * Add few more scripts * Fix scripts * Fix few things * Fix tutorial table * Restructure * Rename * Few fixes and moves * Move sections * Fix bib * Refactor files * Fixes * Fix * Fix few issues * remove scripts * Update docs --------- Co-authored-by: Pablo Garay <palenq@gmail.com>
What does this PR do ?
Refactor NeMo Developer Docs 1st PR. In this PR, we restructured the dev doc as screen shot below. More contents yet to be added.
Changelog
Usage
# Add a code snippet demonstrating how to use this
Jenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkins
on the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information