Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New mcore transformer block spec #9035

Merged
merged 2 commits into from
Jul 26, 2024
Merged

New mcore transformer block spec #9035

merged 2 commits into from
Jul 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 24, 2024 •
edited by gautham-kollu
Loading

What does this PR do ?

This PR leverages new mcore gpt spec handling. (not yet merged to mcore)

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot requested a review from jbaczek April 24, 2024 22:37
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 9, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this May 16, 2024
@jbaczek jbaczek reopened this May 22, 2024
@ericharper ericharper added Run CICD and removed stale labels Jun 5, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jul 2, 2024

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Jul 2, 2024
@jbaczek jbaczek reopened this Jul 10, 2024
@jbaczek jbaczek requested a review from dimapihtar July 12, 2024 09:55
@jbaczek @ericharper
@pablo-garay @pre-commit-ci
New mcore transformer block spec (#8925)
a7ae71d 
* update package info (#8793)

Signed-off-by: eharper <eharper@nvidia.com>

* update mcore (#8917)

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Use new mcore transformer block config handling

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* API fixes

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert chages to CI and Dockerfile

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
@jbaczek jbaczek force-pushed the cherry-pick-main-8f95646fb5ac588bfa60b60e58b79be630d7846e branch from 0a2c85c to a7ae71d Compare July 19, 2024 15:27
@jbaczek
Adjust function calls after branch rebase
ee8e225 
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
@gautham-kollu gautham-kollu self-requested a review July 24, 2024 19:11
dimapihtar
dimapihtar approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jbaczek jbaczek merged commit 7506f98 into main Jul 26, 2024
332 of 407 checks passed
@jbaczek jbaczek deleted the cherry-pick-main-8f95646fb5ac588bfa60b60e58b79be630d7846e branch July 26, 2024 17:38
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
@github-actions @jbaczek
@ericharper @pablo-garay @pre-commit-ci @BoxiangW
New mcore transformer block spec (NVIDIA#9035)
10a6dfe 
* New mcore transformer block spec (NVIDIA#8925)

* update package info (NVIDIA#8793)

Signed-off-by: eharper <eharper@nvidia.com>

* update mcore (NVIDIA#8917)

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Use new mcore transformer block config handling

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* API fixes

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert chages to CI and Dockerfile

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Adjust function calls after branch rebase

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: jbaczek <45043825+jbaczek@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jan Baczek <jbaczek@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
@github-actions @jbaczek
@ericharper @pablo-garay @pre-commit-ci
New mcore transformer block spec (NVIDIA#9035)
d2a0b46 
* New mcore transformer block spec (NVIDIA#8925)

* update package info (NVIDIA#8793)

Signed-off-by: eharper <eharper@nvidia.com>

* update mcore (NVIDIA#8917)

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Use new mcore transformer block config handling

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* API fixes

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert chages to CI and Dockerfile

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Adjust function calls after branch rebase

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: jbaczek <45043825+jbaczek@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jan Baczek <jbaczek@nvidia.com>
Signed-off-by: Vivian Chen <xuanzic@example.com>
terrykong added a commit to NVIDIA/NeMo-Aligner that referenced this pull request Aug 23, 2024
@terrykong
Updates usage of get_specs API to accept transformer_config instead o…
7648697 
…f transformer_config.num_moe_experts

 NVIDIA/NeMo#9035
terrykong added a commit to NVIDIA/NeMo-Aligner that referenced this pull request Sep 16, 2024
@terrykong
Updates usage of get_specs API to accept transformer_config instead o…
629c862 
…f transformer_config.num_moe_experts

 NVIDIA/NeMo#9035
terrykong added a commit to NVIDIA/NeMo-Aligner that referenced this pull request Sep 18, 2024
@terrykong
Updates usage of get_specs API to accept transformer_config instead o…
17a0edb 
…f transformer_config.num_moe_experts

 NVIDIA/NeMo#9035
terrykong added a commit to NVIDIA/NeMo-Aligner that referenced this pull request Sep 27, 2024
@terrykong
Updates usage of get_specs API to accept transformer_config instead o…
9312d23 
…f transformer_config.num_moe_experts

 NVIDIA/NeMo#9035
terrykong added a commit to NVIDIA/NeMo-Aligner that referenced this pull request Sep 27, 2024
@terrykong
Updates usage of get_specs API to accept transformer_config instead o…
6ca9bc1 
…f transformer_config.num_moe_experts

 NVIDIA/NeMo#9035
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
@github-actions @jbaczek
@ericharper @pablo-garay @pre-commit-ci @monica-sekoyan
New mcore transformer block spec (#9035)
5632801 
* New mcore transformer block spec (#8925)

* update package info (#8793)

Signed-off-by: eharper <eharper@nvidia.com>

* update mcore (#8917)

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Use new mcore transformer block config handling

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* API fixes

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert chages to CI and Dockerfile

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Adjust function calls after branch rebase

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: jbaczek <45043825+jbaczek@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jan Baczek <jbaczek@nvidia.com>
terrykong added a commit to NVIDIA/NeMo-Aligner that referenced this pull request Oct 25, 2024
@terrykong
Updates usage of get_specs API to accept transformer_config instead o…
a0e8b78 
…f transformer_config.num_moe_experts

 NVIDIA/NeMo#9035
terrykong added a commit to NVIDIA/NeMo-Aligner that referenced this pull request Nov 1, 2024
@terrykong
Updates usage of get_specs API to accept transformer_config instead o…
c5ac655 
…f transformer_config.num_moe_experts

 NVIDIA/NeMo#9035

Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong added a commit to NVIDIA/NeMo-Aligner that referenced this pull request Nov 1, 2024
@terrykong
Updates usage of get_specs API to accept transformer_config instead o…
a5e10de 
…f transformer_config.num_moe_experts

 NVIDIA/NeMo#9035

Signed-off-by: Terry Kong <terryk@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
@github-actions @jbaczek
@ericharper @pablo-garay @pre-commit-ci
New mcore transformer block spec (NVIDIA#9035)
700d6a8 
* New mcore transformer block spec (NVIDIA#8925)

* update package info (NVIDIA#8793)

Signed-off-by: eharper <eharper@nvidia.com>

* update mcore (NVIDIA#8917)

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Use new mcore transformer block config handling

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* API fixes

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert chages to CI and Dockerfile

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Adjust function calls after branch rebase

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: jbaczek <45043825+jbaczek@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jan Baczek <jbaczek@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
@github-actions @jbaczek
@ericharper @pablo-garay @pre-commit-ci @XuesongYang
New mcore transformer block spec (NVIDIA#9035)
f94fea5 
* New mcore transformer block spec (NVIDIA#8925)

* update package info (NVIDIA#8793)

Signed-off-by: eharper <eharper@nvidia.com>

* update mcore (NVIDIA#8917)

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Use new mcore transformer block config handling

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* API fixes

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert chages to CI and Dockerfile

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Adjust function calls after branch rebase

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: jbaczek <45043825+jbaczek@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jan Baczek <jbaczek@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimapihtar dimapihtar dimapihtar approved these changes

@jbaczek jbaczek Awaiting requested review from jbaczek

@gautham-kollu gautham-kollu Awaiting requested review from gautham-kollu

Assignees
No one assigned
Labels
cherry-pick NLP Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimapihtar @ericharper @gautham-kollu @jbaczek