Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix missing variables and argument changes to MegatronPretrainingRandomSampler #9458

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jstjohn
Copy link
Collaborator

@jstjohn jstjohn commented Jun 12, 2024

What does this PR do ?

Argument changes and non-existent variables are referenced inside of the MegatronPretrainingRandomSampler are addressed.

Collection: lightning

Changelog

  • Remove the dataset input that was erroneously being passed to MegatronPretrainingRandomSampler init.
  • Since self.data_parallel_size doesn't actually exist inside of MegatronPretrainingRandomSampler, infer it from other variables that do exist.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

@jstjohn jstjohn requested a review from marcromeyn June 12, 2024 22:43
@jstjohn jstjohn self-assigned this Jun 12, 2024
@jstjohn jstjohn merged commit 5fa95ce into main Jun 13, 2024
112 checks passed
@jstjohn jstjohn deleted the jstjohn/fix-megatron-cyclic-sampler branch June 13, 2024 14:14
JesusPaz pushed a commit to JesusPaz/NeMo that referenced this pull request Jun 18, 2024
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants