Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RNNT alignments test #9770

Merged
merged 17 commits into from
Jul 24, 2024
Merged

Fix RNNT alignments test #9770

merged 17 commits into from
Jul 24, 2024

Conversation

artbataev
Copy link
Collaborator

@artbataev artbataev commented Jul 17, 2024 •
edited
Loading

What does this PR do ?

Refactor RNN-T alignments tests (failure observed in #9739):

  • use fixture to avoid loading the model multiple time
  • the test now can run on arbitrary machine (not only on CI)

Collection: [ASR]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

artbataev added 3 commits July 17, 2024 21:44
@artbataev
Make alignments tests work on any machine
8a31035 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev
Fix device
2f9ff72 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev
Try 24.03 container on CI
9647ff3 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
artbataev and others added 2 commits July 17, 2024 17:48
@artbataev
Avoid saving model
2fa6724 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev
Update Dockerfile: use 24.03 container
4306443 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev artbataev changed the title Fix rnnt alignments test Update to PyTorch 24.03. Fix RNNT alignments test Jul 18, 2024
@artbataev artbataev marked this pull request as ready for review July 18, 2024 08:20
@artbataev artbataev requested a review from pablo-garay July 18, 2024 09:57
@artbataev
Disable broken tests
c07e19b 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev
Apply isort and black reformatting
2b68e0c 
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
artbataev added 2 commits July 18, 2024 17:33
@artbataev
Fix huggingface_hub
12d96af 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev
Merge remote-tracking branch 'origin/fix_rnnt_alignments_test' into f…
ca19913 
…ix_rnnt_alignments_test
@artbataev
Merge branch 'r2.0.0rc1' into fix_rnnt_alignments_test
f7e90dc 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev
Revert changes related to 24.03 container
4d0fec1 
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev artbataev changed the title Update to PyTorch 24.03. Fix RNNT alignments test Fix RNNT alignments test Jul 23, 2024
@artbataev artbataev merged commit 5aed2c0 into r2.0.0rc1 Jul 24, 2024
117 of 118 checks passed
@artbataev artbataev deleted the fix_rnnt_alignments_test branch July 24, 2024 14:30
artbataev added a commit that referenced this pull request Jul 24, 2024
@artbataev
Fix RNNT alignments test (#9770)
342f310 
* Make alignments tests work on any machine

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

---------

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
@artbataev artbataev mentioned this pull request Jul 24, 2024
Merged
8 tasks
pablo-garay pushed a commit that referenced this pull request Jul 24, 2024
@artbataev
Fix RNNT alignments test (#9770) (#9862)
a022765 
* Make alignments tests work on any machine



---------

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
@artbataev @akoumpa
Fix RNNT alignments test (#9770) (#9862)
ca099f7 
* Make alignments tests work on any machine

---------

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
@artbataev @BoxiangW
Fix RNNT alignments test (NVIDIA#9770) (NVIDIA#9862)
f54331f 
* Make alignments tests work on any machine

---------

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
@artbataev
Fix RNNT alignments test (NVIDIA#9770) (NVIDIA#9862)
67c9891 
* Make alignments tests work on any machine

---------

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: Vivian Chen <xuanzic@example.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
@artbataev @monica-sekoyan
Fix RNNT alignments test (#9770) (#9862)
8fb5597 
* Make alignments tests work on any machine



---------

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
@artbataev
Fix RNNT alignments test (NVIDIA#9770) (NVIDIA#9862)
30458ad 
* Make alignments tests work on any machine



---------

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-garay pablo-garay pablo-garay approved these changes

Assignees
No one assigned
Labels
ASR CI Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artbataev @pablo-garay