Efficient Workflow Cleanup through Using Async Operations for Log Migration #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethany-nv
had a problem deploying
to
internal-ci
GitHub Actions
Failure
xutongNV
reviewed
Dec 18, 2025
ethany-nv
had a problem deploying
to
internal-ci
GitHub Actions
Failure
xutongNV
previously approved these changes
Dec 18, 2025
Contributor
xutongNV
left a comment
xutongNV
left a comment
There was a problem hiding this comment.
have you test this with a big workflow?
RyaliNvidia
previously approved these changes
Dec 18, 2025
ethany-nv
had a problem deploying
to
internal-ci
GitHub Actions
Failure
ethany-nv
had a problem deploying
to
internal-ci
GitHub Actions
Error
ethany-nv
had a problem deploying
to
internal-ci
GitHub Actions
Failure
ethany-nv
had a problem deploying
to
internal-ci
GitHub Actions
Failure
ethany-nv
had a problem deploying
to
internal-ci
GitHub Actions
Error
ethany-nv
temporarily deployed
to
internal-ci
GitHub Actions
Inactive
ethany-nv
changed the title
|
fernandol-nvidia
approved these changes
Jan 16, 2026
RyaliNvidia
approved these changes
Jan 16, 2026
patclarknvidia
added a commit
that referenced
this pull request
Jan 20, 2026
* allow flexible squid proxy replicas (#241) * allow flexible squid proxy replicas * fix * Efficient Workflow Cleanup through Using Async Operations for Log Migration (#167) * Improving Performance for Uploading Workflow Artifacts in Worker Jobs * Cleanup * Add progress writing after upload * Add dependency in Bazel BUILD * Add type to mypy requirements * Update mypy requirements * Add to mypy_cli BUILD * Fix lint * Comment * Use constant to define semaphor and storage client executor count * #244 - Use last login url if url is not specified (#245) * Use last login url if url is not specified * print message * Cannot select any text inside modals or slideouts (#248) * Video html element not changin when selecting different video files in the UI for OSMO dataset (#249) --------- Co-authored-by: Vivian Pan <vivianp@nvidia.com> Co-authored-by: ethany-nv <ethany@nvidia.com> Co-authored-by: RyaliNvidia <ryali@nvidia.com> Co-authored-by: patclarknvidia <patc@nvidia.com>
xutongNV
added a commit
that referenced
this pull request
Jan 20, 2026
* Update the wording re: creating feature branches (#204) * Add a link back to OSMO from the brev launchable (#205) * Improve styling for badges in the brev launchable readme (#207) * Fix osmo config pool update payload in backend installation docs (#210) * Fix osmo config pool update payload in practical guide (#213) * #147 - backend operator redesign doc (#149) * backend operator redesign doc * 195 - Bump quick-start version due to updated dependencies (#217) * Perform Client Side Data Auth Check In the Event of Environment Based Auth (#177) * Data/Dataset Auth Check CLIs * Remove auth check from data service * Use auth check CLIs in ctrl * Add exit code to docs * Fix build issues * Fix lint * Ctrl to use user config when validating data auth * Use the correct CLI argument type * Fix lint * Use profile when looking up data credential from config * Update quick start installation to always install latest version (#218) * Add workflow to label external issues and pull requests (#222) * Add workflow to label external issues and pull requests * pin to allowed action version * add reopened event * allow flexible squid proxy replicas (#241) * allow flexible squid proxy replicas * fix * Efficient Workflow Cleanup through Using Async Operations for Log Migration (#167) * Improving Performance for Uploading Workflow Artifacts in Worker Jobs * Cleanup * Add progress writing after upload * Add dependency in Bazel BUILD * Add type to mypy requirements * Update mypy requirements * Add to mypy_cli BUILD * Fix lint * Comment * Use constant to define semaphor and storage client executor count * #244 - Use last login url if url is not specified (#245) * Use last login url if url is not specified * print message * Cannot select any text inside modals or slideouts (#248) * Video html element not changin when selecting different video files in the UI for OSMO dataset (#249) --------- Co-authored-by: Ethan Look-Potts <elookpotts@nvidia.com> Co-authored-by: xutongNV <xutongr@nvidia.com> Co-authored-by: Fernando L <fernandol@nvidia.com> Co-authored-by: Vivian Pan <vivianp@nvidia.com> Co-authored-by: ethany-nv <ethany@nvidia.com> Co-authored-by: RyaliNvidia <ryali@nvidia.com> Co-authored-by: patclarknvidia <patc@nvidia.com>
RyaliNvidia
added a commit
that referenced
this pull request
Jan 20, 2026
* allow flexible squid proxy replicas (#241) * allow flexible squid proxy replicas * fix * Efficient Workflow Cleanup through Using Async Operations for Log Migration (#167) * Improving Performance for Uploading Workflow Artifacts in Worker Jobs * Cleanup * Add progress writing after upload * Add dependency in Bazel BUILD * Add type to mypy requirements * Update mypy requirements * Add to mypy_cli BUILD * Fix lint * Comment * Use constant to define semaphor and storage client executor count * #244 - Use last login url if url is not specified (#245) * Use last login url if url is not specified * print message * Cannot select any text inside modals or slideouts (#248) * Video html element not changin when selecting different video files in the UI for OSMO dataset (#249) --------- Co-authored-by: Vivian Pan <vivianp@nvidia.com> Co-authored-by: ethany-nv <ethany@nvidia.com> Co-authored-by: RyaliNvidia <ryali@nvidia.com> Co-authored-by: patclarknvidia <patc@nvidia.com>
xutongNV
added a commit
that referenced
this pull request
Jan 20, 2026
* Update the wording re: creating feature branches (#204) * Add a link back to OSMO from the brev launchable (#205) * Improve styling for badges in the brev launchable readme (#207) * Fix osmo config pool update payload in backend installation docs (#210) * Fix osmo config pool update payload in practical guide (#213) * #147 - backend operator redesign doc (#149) * backend operator redesign doc * 195 - Bump quick-start version due to updated dependencies (#217) * Perform Client Side Data Auth Check In the Event of Environment Based Auth (#177) * Data/Dataset Auth Check CLIs * Remove auth check from data service * Use auth check CLIs in ctrl * Add exit code to docs * Fix build issues * Fix lint * Ctrl to use user config when validating data auth * Use the correct CLI argument type * Fix lint * Use profile when looking up data credential from config * Update quick start installation to always install latest version (#218) * Add workflow to label external issues and pull requests (#222) * Add workflow to label external issues and pull requests * pin to allowed action version * add reopened event * allow flexible squid proxy replicas (#241) * allow flexible squid proxy replicas * fix * Efficient Workflow Cleanup through Using Async Operations for Log Migration (#167) * Improving Performance for Uploading Workflow Artifacts in Worker Jobs * Cleanup * Add progress writing after upload * Add dependency in Bazel BUILD * Add type to mypy requirements * Update mypy requirements * Add to mypy_cli BUILD * Fix lint * Comment * Use constant to define semaphor and storage client executor count * #244 - Use last login url if url is not specified (#245) * Use last login url if url is not specified * print message * Cannot select any text inside modals or slideouts (#248) * Video html element not changin when selecting different video files in the UI for OSMO dataset (#249) * sync-feature-branches: fix no conflict case, allow single branch to be synced (#252) * Fix sync-feature-branches with no merge conflicts * Allow a single branch to be specified for sync-feature-branches * Perform operations as OSMO CI Bot * Add external label when the PR is created * extract issue number * add test cases (#247) --------- Co-authored-by: Ethan Look-Potts <elookpotts@nvidia.com> Co-authored-by: xutongNV <xutongr@nvidia.com> Co-authored-by: Fernando L <fernandol@nvidia.com> Co-authored-by: Vivian Pan <vivianp@nvidia.com> Co-authored-by: ethany-nv <ethany@nvidia.com> Co-authored-by: RyaliNvidia <ryali@nvidia.com> Co-authored-by: patclarknvidia <patc@nvidia.com>
RyaliNvidia
added a commit
that referenced
this pull request
Jan 22, 2026
* allow flexible squid proxy replicas (#241) * allow flexible squid proxy replicas * fix * Efficient Workflow Cleanup through Using Async Operations for Log Migration (#167) * Improving Performance for Uploading Workflow Artifacts in Worker Jobs * Cleanup * Add progress writing after upload * Add dependency in Bazel BUILD * Add type to mypy requirements * Update mypy requirements * Add to mypy_cli BUILD * Fix lint * Comment * Use constant to define semaphor and storage client executor count * #244 - Use last login url if url is not specified (#245) * Use last login url if url is not specified * print message * Cannot select any text inside modals or slideouts (#248) * Video html element not changin when selecting different video files in the UI for OSMO dataset (#249) * sync-feature-branches: fix no conflict case, allow single branch to be synced (#252) * Fix sync-feature-branches with no merge conflicts * Allow a single branch to be specified for sync-feature-branches * Perform operations as OSMO CI Bot * Add external label when the PR is created * extract issue number * add test cases (#247) * Allow PR checks to run on release branches (#264) * Database Pooling in Postgres Singleton Across Services (#251) * Initial commit for database pooling * Update set_session * Fix lint * Update PostgresConnector to have semaphor to control connections * Lint fix * Fix number of maxconn for test * Address comments * Add Go Postgres utils (#272) * #148 - Auth Project Design Documents (#165) * fix conflict * fix conflict * fix --------- Co-authored-by: Vivian Pan <vivianp@nvidia.com> Co-authored-by: ethany-nv <ethany@nvidia.com> Co-authored-by: RyaliNvidia <ryali@nvidia.com> Co-authored-by: patclarknvidia <patc@nvidia.com> Co-authored-by: Ethan Look-Potts <elookpotts@nvidia.com> Co-authored-by: xutongNV <xutongr@nvidia.com>
xutongNV
added a commit
that referenced
this pull request
Jan 22, 2026
* Update the wording re: creating feature branches (#204) * Add a link back to OSMO from the brev launchable (#205) * Improve styling for badges in the brev launchable readme (#207) * Fix osmo config pool update payload in backend installation docs (#210) * Fix osmo config pool update payload in practical guide (#213) * #147 - backend operator redesign doc (#149) * backend operator redesign doc * 195 - Bump quick-start version due to updated dependencies (#217) * Perform Client Side Data Auth Check In the Event of Environment Based Auth (#177) * Data/Dataset Auth Check CLIs * Remove auth check from data service * Use auth check CLIs in ctrl * Add exit code to docs * Fix build issues * Fix lint * Ctrl to use user config when validating data auth * Use the correct CLI argument type * Fix lint * Use profile when looking up data credential from config * Update quick start installation to always install latest version (#218) * Add workflow to label external issues and pull requests (#222) * Add workflow to label external issues and pull requests * pin to allowed action version * add reopened event * allow flexible squid proxy replicas (#241) * allow flexible squid proxy replicas * fix * Efficient Workflow Cleanup through Using Async Operations for Log Migration (#167) * Improving Performance for Uploading Workflow Artifacts in Worker Jobs * Cleanup * Add progress writing after upload * Add dependency in Bazel BUILD * Add type to mypy requirements * Update mypy requirements * Add to mypy_cli BUILD * Fix lint * Comment * Use constant to define semaphor and storage client executor count * #244 - Use last login url if url is not specified (#245) * Use last login url if url is not specified * print message * Cannot select any text inside modals or slideouts (#248) * Video html element not changin when selecting different video files in the UI for OSMO dataset (#249) * sync-feature-branches: fix no conflict case, allow single branch to be synced (#252) * Fix sync-feature-branches with no merge conflicts * Allow a single branch to be specified for sync-feature-branches * Perform operations as OSMO CI Bot * Add external label when the PR is created * extract issue number * add test cases (#247) * Allow PR checks to run on release branches (#264) * Database Pooling in Postgres Singleton Across Services (#251) * Initial commit for database pooling * Update set_session * Fix lint * Update PostgresConnector to have semaphor to control connections * Lint fix * Fix number of maxconn for test * Address comments * Add Go Postgres utils (#272) * #148 - Auth Project Design Documents (#165) --------- Co-authored-by: Ethan Look-Potts <elookpotts@nvidia.com> Co-authored-by: xutongNV <xutongr@nvidia.com> Co-authored-by: Fernando L <fernandol@nvidia.com> Co-authored-by: Vivian Pan <vivianp@nvidia.com> Co-authored-by: ethany-nv <ethany@nvidia.com> Co-authored-by: RyaliNvidia <ryali@nvidia.com> Co-authored-by: patclarknvidia <patc@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses asyncio to migrate logs for all the tasks within a workflow concurrently. Previously, the worker would synchronously migrate logs from Redis to cloud storage per task, which was inefficient.
This PR also batches together delete operations to increase the speed of clearing all the stale Redis keys.
Issue #174
Experiment
To see the performance gain of this optimization, we measure the duration of the
CleanupWorkflowtask when running large group workflows on two different OSMO instances - one without and one with the optimization. For each workflow ran, each task outputs 5000 lines.Checklist