Check for negative cluster number in compute_sky_visibility() #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163.
cluster == -1seems to be a legitimate case as that value is set inbsp_mesh.c:719.I didn't dig deeper into the circumstances under which that happens (though it may be worthwhile, if only for documentation/commenting purposes).
But, as can be seen from the code, that value causes an out-of-bounds array access.
Curiously, this access would happen on Windows as well, not just Linux; I guess it's only manifesting as a crash there due to compiler differences (codegen, or perhaps data alignment/arrangement) or ABI differences.