materials: Make fallback radiance (used when no BSP radiance given) an explicit attribute #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
res2k
force-pushed
the
material-bsp_radiance
branch
from
15cbada to
c8d6aa8
Compare
alex-leleka
pushed a commit
to alex-leleka/Q2RTX
that referenced
this pull request
Jan 24, 2023
Instead of swapping texture 0 with lightmap and disabling lightmapping, bind white texture to texture 0. Also disable intensity bit. Fixes NVIDIA#210.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach decided on the fallback radiance value based on whether the emissive image was fake or not.
However, there are cases where having a synthesized emissive texture to be "always emissive" is beneficial -
e.g. the material was sometimes used as an emissive surface, but in other cases manually placed lights were used (and the "BSP radiance" is 0).
Since we don't support point lights, having the surface take over lighting duties here is helpful.
(If you want a practical example:
textures/dark_1/0text_59on xatrix'xswampmap.)This PR also contains non-related developer and user quality of life changes.