-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[TRTLLM-6537][infra] extend multi-gpu tests related file list #6139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the list of file paths and directories monitored by the Changes
Sequence Diagram(s)sequenceDiagram
participant PR as Pull Request
participant Jenkins as Jenkins Pipeline
participant L0_Merge as L0_MergeRequest.groovy
PR->>Jenkins: Submit PR with changed files
Jenkins->>L0_Merge: Call getMultiGpuFileChanged(changed_files)
L0_Merge->>L0_Merge: Check changed_files against updated path/directory list
alt Match found
L0_Merge-->>Jenkins: Return true (trigger multi-GPU test)
else No match
L0_Merge-->>Jenkins: Return false (do not trigger)
end
Estimated code review effort1 (~5 minutes) Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
a4fed20
to
ccbd4fe
Compare
/bot run |
2 similar comments
/bot run |
/bot run |
PR_Github #12414 [ run ] triggered by Bot |
/bot kill |
/bot run |
PR_Github #12435 [ kill ] triggered by Bot |
PR_Github #12414 [ run ] completed with state |
PR_Github #12435 [ kill ] completed with state |
PR_Github #12436 [ run ] triggered by Bot |
PR_Github #12436 [ run ] completed with state |
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
ccbd4fe
to
ac83495
Compare
/bot run |
PR_Github #12496 [ run ] triggered by Bot |
PR_Github #12496 [ run ] completed with state |
/bot run |
PR_Github #12507 [ run ] triggered by Bot |
PR_Github #12507 [ run ] completed with state |
/bot run |
PR_Github #12525 [ run ] triggered by Bot |
PR_Github #12525 [ run ] completed with state |
Summary by CodeRabbit
Description
Extend multi-gpu tests related file list. It covers all files in
tensorrt_llm/batch_manager
andtensorrt_llm/executor
and is sorted now.Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]
to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]
Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast
(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test
(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"
(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"
(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test
(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test
(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test
(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge
(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"
(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md
.kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request.
--comment "Reason for skipping build/test"
is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.