Skip to content

[TRTLLM-6537][infra] extend multi-gpu tests related file list #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

reasonsolo
Copy link
Collaborator

@reasonsolo reasonsolo commented Jul 17, 2025

Summary by CodeRabbit

  • Chores
    • Expanded and reorganized the list of files and directories that trigger multi-GPU testing, improving coverage and maintainability. No changes to user-facing features or functionality.

Description

Extend multi-gpu tests related file list. It covers all files in tensorrt_llm/batch_manager and tensorrt_llm/executor and is sorted now.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Copy link

coderabbitai bot commented Jul 17, 2025

Walkthrough

The change updates the list of file paths and directories monitored by the getMultiGpuFileChanged function in jenkins/L0_MergeRequest.groovy for triggering multi-GPU testing. It replaces many explicit file entries with broader directory prefixes, adds new directories, removes certain files, reorders the list, and includes jenkins/L0_Test.groovy. The core logic of the function remains unchanged.

Changes

File(s) Change Summary
jenkins/L0_MergeRequest.groovy Modified getMultiGpuFileChanged list: added new directory prefixes, replaced explicit files with directories, removed some files, reordered entries, and added jenkins/L0_Test.groovy. No logic changes.

Sequence Diagram(s)

sequenceDiagram
    participant PR as Pull Request
    participant Jenkins as Jenkins Pipeline
    participant L0_Merge as L0_MergeRequest.groovy

    PR->>Jenkins: Submit PR with changed files
    Jenkins->>L0_Merge: Call getMultiGpuFileChanged(changed_files)
    L0_Merge->>L0_Merge: Check changed_files against updated path/directory list
    alt Match found
        L0_Merge-->>Jenkins: Return true (trigger multi-GPU test)
    else No match
        L0_Merge-->>Jenkins: Return false (do not trigger)
    end
Loading

Estimated code review effort

1 (~5 minutes)

Possibly related PRs

  • NVIDIA/TensorRT-LLM#6131: Both PRs update the list of file paths in getMultiGpuFileChanged to adjust multi-GPU test triggers.
  • NVIDIA/TensorRT-LLM#6113: This PR modifies the Jenkins pipeline logic in jenkins/L0_Test.groovy, which is now included in the multi-GPU trigger list by the current PR.

Suggested reviewers

  • HuiGao-NV
  • leslie-fang25
  • jinyangyuan-nvidia

Poem

In Jenkins’ den, where pipelines dwell,
The file list grew, directories swell.
Batch managers, executors join the queue,
With broader sweeps for triggers new.
A bunny hops and checks with glee—
“Multi-GPU tests? Let’s see!”
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccbd4fe and ac83495.

📒 Files selected for processing (1)
  • jenkins/L0_MergeRequest.groovy (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • jenkins/L0_MergeRequest.groovy

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@reasonsolo reasonsolo requested a review from Shixiaowei02 July 17, 2025 09:27
@reasonsolo reasonsolo force-pushed the multigpu_test_list branch from a4fed20 to ccbd4fe Compare July 18, 2025 02:38
@reasonsolo
Copy link
Collaborator Author

/bot run

2 similar comments
@reasonsolo
Copy link
Collaborator Author

/bot run

@reasonsolo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12414 [ run ] triggered by Bot

@reasonsolo reasonsolo self-assigned this Jul 21, 2025
@reasonsolo
Copy link
Collaborator Author

/bot kill

@reasonsolo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12435 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12414 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12435 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit ccbd4fe

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12436 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12436 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9248 completed with status: 'FAILURE'

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@reasonsolo reasonsolo force-pushed the multigpu_test_list branch from ccbd4fe to ac83495 Compare July 22, 2025 01:35
@reasonsolo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12496 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12496 [ run ] completed with state FAILURE

@reasonsolo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12507 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12507 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #9295 completed with status: 'FAILURE'

@reasonsolo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12525 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12525 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9309 completed with status: 'SUCCESS'

@reasonsolo reasonsolo merged commit 3e1a0fb into NVIDIA:main Jul 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants