Use right CMake variable for cu files in GroupNorm #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In groupNormalizationPlugin, the .cu files are not added to PLUGIN_CU_SOURCES, contrary to other plugins. This is problematic because the NVCC flags are not set correctly when compiling those .cu files, e.g. GENCODES. While this is not a direct issue for this plugin in particular, it should be fixed as the documentation refers to it for building new plugings. Signed-off-by: Mickaël Seznec <mickael.seznec@gmail.com>
pranavm-nvidia
approved these changes
Feb 24, 2021
rajeevsrao
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In groupNormalizationPlugin, the .cu files are not added to
PLUGIN_CU_SOURCES, contrary to other plugins.
This is problematic because the NVCC flags are not set correctly when
compiling those .cu files, e.g. GENCODES.
While this is not a direct issue for this plugin in particular, it
should be fixed as the documentation refers to it for building new
plugings.
Signed-off-by: Mickaël Seznec mickael.seznec@gmail.com