Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efficientNMSPlugin: support class-independent nms with new parameter class_agnostic #2645

Open
wants to merge 3 commits into
base: release/8.6
Choose a base branch
from
Open

efficientNMSPlugin: support class-independent nms with new parameter class_agnostic #2645

wants to merge 3 commits into from

Conversation

yili123123
Copy link

@yili123123 yili123123 commented Feb 7, 2023 •
edited
Loading

@rajeevsrao @pranavm-nvidia @samurdhikaru ,sorry for closing the previous pull request by mistake. Could you take your time to review the new PR?

Some object detection networks/architectures like YOLO series need to use class independent nms operations. Now we can do class independent nms when the class_agnostic is enabled, otherwise, different class would do nms respectively.

yili123123 and others added 2 commits January 6, 2023 23:26
@yili123123
efficientNMSPlugin: support class-independent nms with new parameter …
d217aed 
…class_agnostic

Signed-off-by: yili123123 <yiliyili123@outlook.com>
@yili123123 @samurdhikaru
Apply suggestions from code review
6d52bd9 
Signed-off-by: yili123123 <120350735+yili123123@users.noreply.github.com>

Co-authored-by: Samurdhi Karunaratne <97725867+samurdhikaru@users.noreply.github.com>
@yili123123 yili123123 mentioned this pull request Feb 7, 2023
Closed
@tadejsv
Copy link

tadejsv commented Feb 11, 2023

Would really love to see this merged! This functionality would bring the behavior of NMS plugin in line with ONNX and pytorch.

@yili123123
change variable name
15338f4 
Signed-off-by: yili123123 <yiliyili123@outlook.com>
@rajeevsrao
Copy link
Collaborator

@yili123123 thanks for your contribution! We will merge this once the internal review/testing (currently in progress) is completed. @samurdhikaru will coordinate.

@rajeevsrao rajeevsrao added the Plugins Issues when using TensorRT plugins label Mar 16, 2023
@rajeevsrao rajeevsrao changed the base branch from main to release/8.6 March 16, 2023 04:58
@rajeevsrao rajeevsrao added this to the TensorRT-Next milestone Mar 16, 2023
@samurdhikaru
Copy link
Collaborator

@yili123123 Please refer to 76eaca2 to see whether it fulfils the intended purpose. If not, please update the PR accordingly.

@yili123123
Copy link
Author

@yili123123 Please refer to 76eaca2 to see whether it fulfils the intended purpose. If not, please update the PR accordingly.

@samurdhikaru Okay, it fully meets expectations, is there anything else I need to do next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samurdhikaru samurdhikaru samurdhikaru approved these changes

Assignees

@samurdhikaru samurdhikaru

@shuyuelan shuyuelan

Labels
Plugins Issues when using TensorRT plugins
Projects
None yet
Milestone
TensorRT-Next
Development

Successfully merging this pull request may close these issues.
5 participants
@yili123123 @tadejsv @rajeevsrao @samurdhikaru @shuyuelan