Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tkurth/rl ppo #12

Merged
merged 53 commits into from
Jun 12, 2024
Merged

Tkurth/rl ppo #12

merged 53 commits into from
Jun 12, 2024

Conversation

azrael417
Copy link
Collaborator

This PR refactors the RL code for more flexibility. This was necessary for adding on-policy routines, which is also done with PPO along with all C and Fortran wrapper routines. So far, the code still needs to be tested but I wanted to get going on the PR.

@azrael417 azrael417 closed this Apr 16, 2024
@azrael417 azrael417 reopened this Apr 16, 2024
@azrael417 azrael417 force-pushed the tkurth/rl-ppo branch 2 times, most recently from 64b4c9c to 35fec7b Compare April 22, 2024 13:52
@azrael417 azrael417 marked this pull request as ready for review June 4, 2024 07:24
Copy link
Collaborator

@romerojosh romerojosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments (mostly minor). Otherwise, changes LGTM!

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
src/csrc/distributed.cpp Outdated Show resolved Hide resolved
src/csrc/include/internal/rl/off_policy/td3.h Outdated Show resolved Hide resolved
src/csrc/include/internal/rl/on_policy.h Outdated Show resolved Hide resolved
src/csrc/include/internal/rl/policy.h Outdated Show resolved Hide resolved
src/csrc/include/internal/rl/rollout_buffer.h Outdated Show resolved Hide resolved
src/csrc/rl/off_policy/interface.cpp Outdated Show resolved Hide resolved
src/csrc/rl/utils.cpp Outdated Show resolved Hide resolved
docs/api/f_api.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@romerojosh romerojosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@azrael417 azrael417 merged commit 6f76e84 into NVIDIA:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants