remove hardcoded yaml-cpp path from CMakeLists.txt

[TomMelt]

CMakeLists.txt and examples/cpp/cart_pole/CMakeLists.txt contain hardcoded paths to yaml-cpp

These has been removed in favour of using env variables

• YAML_LIBRARY
• YAML_INCLUDE_DIRS

Fixes #6

[azrael417]

LGTM. Josh, any comments?

[romerojosh]

Thanks for working on improving the build for non-Docker users @TomMelt!

Left a couple of comments/changes. Additionally, before we can merge, can you update the Dockerfile to include the definition of this new env var to the TorchFort build line, for example, something like:

RUN cd /torchfort && mkdir build && cd build && \
    cmake -DCMAKE_INSTALL_PREFIX=/opt/torchfort \
    -DNVHPC_CUDA_VERSION=11.8 \
    -DCMAKE_PREFIX_PATH="`python -c 'import torch;print(torch.utils.cmake_prefix_path)'`;/opt/nvidia/hpc_sdk/Linux_x86_64/23.5/cmake" \
    -DYAML_LIBRARY=/opt/yaml-cpp/lib \
    -DYAML_INCLUDE_DIRS=/opt/yaml-cpp/include \
    .. && \
    make -j install && \
    cd / && rm -rf torchfort

[TomMelt]

Thanks for working on improving the build for non-Docker users @TomMelt!

Left a couple of comments/changes. Additionally, before we can merge, can you update the Dockerfile to include the definition of this new env var to the TorchFort build line, for example, something like:

RUN cd /torchfort && mkdir build && cd build && \
    cmake -DCMAKE_INSTALL_PREFIX=/opt/torchfort \
    -DNVHPC_CUDA_VERSION=11.8 \
    -DCMAKE_PREFIX_PATH="`python -c 'import torch;print(torch.utils.cmake_prefix_path)'`;/opt/nvidia/hpc_sdk/Linux_x86_64/23.5/cmake" \
    -DYAML_LIBRARY=/opt/yaml-cpp/lib \
    -DYAML_INCLUDE_DIRS=/opt/yaml-cpp/include \
    .. && \
    make -j install && \
    cd / && rm -rf torchfort

Hi @romerojosh , I have update the Dockerfile to include the YAML_CPP_ROOT CMake variable. It should be sufficient.

https://github.com/TomMelt/TorchFort/blob/533768dc4ea475331e97fdbc9fa472fa2bfa6659/docker/Dockerfile#L52

(annoyingly I can't test the docker build easily without making a virtual machine because the docker script doesn't work on ubuntu zfs install due to issues with overlayFS and the ZFS filesystems)

[romerojosh]

LGTM! Thanks for the PR!