[Common] Moved framework agnostic THD kernels to common. #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoldfarb-nvidia
force-pushed
the
mgoldfarb/move_thd_fused_attn_utils_to_common
branch
from
94a75ac
to
81718ac
Compare
mgoldfarb-nvidia
force-pushed
the
mgoldfarb/move_thd_fused_attn_utils_to_common
branch
4 times, most recently
from
685ad1b
to
3ee113e
Compare
|
/te-ci pytorch |
xrennvidia
reviewed
Nov 18, 2024
mgoldfarb-nvidia
force-pushed
the
mgoldfarb/move_thd_fused_attn_utils_to_common
branch
from
17eca08
to
6308a03
Compare
|
/te-ci pytorch |
|
/te-ci pytorch L1 |
|
FYI, it seems like pipeline |
|
Probably needs to add |
mgoldfarb-nvidia
force-pushed
the
mgoldfarb/move_thd_fused_attn_utils_to_common
branch
2 times, most recently
from
71bd3cb
to
940fd65
Compare
|
/te-ci pytorch L1 |
Signed-off-by: Michael Goldfarb <mgoldfarb@nvidia.com>
mgoldfarb-nvidia
force-pushed
the
mgoldfarb/move_thd_fused_attn_utils_to_common
branch
from
03b0400
to
89fcca9
Compare
Signed-off-by: Michael Goldfarb <mgoldfarb@nvidia.com>
|
/te-ci pytorch L1 |
| @@ -70,6 +70,7 @@ jobs: | |||
| run: pip install . -v | |||
| env: | |||
| NVTE_FRAMEWORK: jax | |||
| MAX_JOBS: 1 | |||
There was a problem hiding this comment.
cc @timmoon10
Signed-off-by: Michael Goldfarb <mgoldfarb@nvidia.com>
|
/te-ci pytorch L1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves several kernels that are used for context parallelism + THD fused attention to shared location so they can be called by Jax and other frameworks.
Type of change
Changes
Moves common code out of pytorch filder.
Checklist: