Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle] Replace paddle.fluid imports with paddle.base #633

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

timmoon10
Copy link
Collaborator

Paddle 2.6.0 renamed paddle.fluid to paddle.base (see PaddlePaddle/Paddle#56576).

@timmoon10 timmoon10 added the bug Something isn't working label Jan 26, 2024
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10
Copy link
Collaborator Author

/te-ci paddle

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10
Copy link
Collaborator Author

/te-ci paddle

@jeng1220
Copy link
Contributor

@Wong4j ,
Please review this PR and ensure that it can run with both Paddle 2.5.2 and Paddle 2.6.0.

@Wong4j
Copy link
Contributor

Wong4j commented Jan 30, 2024

@Wong4j , Please review this PR and ensure that it can run with both Paddle 2.5.2 and Paddle 2.6.0.

LGTM.
I have checked this PR with both Paddle 2.5.2 and Paddle 2.6.0. All the UTs passed.

Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member

/te-ci paddle

@timmoon10 timmoon10 merged commit 8d3b62d into NVIDIA:main Jan 30, 2024
9 checks passed
@timmoon10 timmoon10 deleted the paddle-fluid-bugfix branch January 30, 2024 18:30
Oleg-Goncharov pushed a commit to Oleg-Goncharov/TransformerEngine that referenced this pull request Jan 30, 2024
* Replace paddle.fluid imports with paddle.base

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* Remove paddle.fluid usage from tests

Signed-off-by: Tim Moon <tmoon@nvidia.com>

---------

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
ksivaman added a commit that referenced this pull request Feb 7, 2024
* Replace paddle.fluid imports with paddle.base

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* Remove paddle.fluid usage from tests

Signed-off-by: Tim Moon <tmoon@nvidia.com>

---------

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants