Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[samples] add inference sample for simple snp trainer #128

Open
wants to merge 6 commits into
base: dev-v0.1.0
Choose a base branch
from

Conversation

ohadmo
Copy link
Member

@ohadmo ohadmo commented Sep 28, 2020

Resolves #110 & #107

@ohadmo ohadmo added the samples label Sep 28, 2020
@ohadmo ohadmo requested a review from tijyojwad September 28, 2020 00:00
@ohadmo ohadmo self-assigned this Sep 28, 2020

# Create test DAG
test_dataset = HDFDataLoader(args.test_hdf, batch_size=32,
shuffle=True, num_workers=args.threads,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I'm thinking about this, I am realizing that we can't use the HDFDataLoader for the inference script here. We'll want to use the ReadPileupDataLoader because that way we'll have access to the Variant entries to serialize outputs to a VCF.

For that one, we also have to set shuffle=False so the inference order is the same as the VCF entries order.

@ohadmo ohadmo marked this pull request as ready for review October 8, 2020 14:06
@ohadmo ohadmo requested a review from tijyojwad October 14, 2020 16:17
@ohadmo ohadmo changed the base branch from master to dev-v0.1.0 November 2, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[samples] add test data for snp trainer
2 participants