p2p communication overlap at interleaved pipelining #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erhoo82
commented
Mar 15, 2023
erhoo82
commented
- Overlap P2P communication with FWD and BWD computes during the 1F1B phase of pipelining. This implementation is only valid at interleaved-pipelining, where P2P communication adds significant performance overhead.
- Use individual send/recv kernel instead of batching multiple send/recv ops with a single kernel. This avoids unnecessary serialization of send/recv ops within a kernel.
fix comments and arguments overlap individual send/recv ops fix for p2p overlap with batched send recv op remove redundancy fix non-overlap case
erhoo82
force-pushed
the
slym/send_recv_overlap
branch
from
e886b5d
to
2c5d09c
Compare
erhoo82
changed the title
crcrpar
reviewed
Mar 17, 2023
Comment on lines
+91
to
+96
| overlap_p2p_comm: If :obj:`True`, returns cuda wait handles to scheduler instead of completing | ||
| the communication within the p2p transfer API instance. The scheduler manages the communication completion | ||
| to overlap with computation. | ||
| batch_p2p_comm: If :obj:`True`, use the batched send and receive api to conduct the communication of | ||
| a collection of send and receive operations between peer. If :obj:`False`, conduct each send and recv operation | ||
| individually. |
There was a problem hiding this comment.
noob question: Can these two arguments be the same value?
There was a problem hiding this comment.
The optimal option, for now, is True for overlap_p2p_comm and False for batch_p2p_comm. But, yes, they could have the same values.
crcrpar
approved these changes
Mar 17, 2023
yuanzhedong
pushed a commit
to yuanzhedong/apex
that referenced
this pull request
Jul 14, 2023
fix comments and arguments overlap individual send/recv ops fix for p2p overlap with batched send recv op remove redundancy fix non-overlap case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.