Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commentary #104

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Fix commentary #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/caffe/layer_factory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,11 @@ shared_ptr<Layer<Dtype> > GetPoolingLayer(const LayerParameter& param) {
} else if (engine == PoolingParameter_Engine_CUDNN) {
PoolingParameter p_param = param.pooling_param();

// CuDNN handles tie breaks differently than Caffe for MaxPooling.
// Until there is a workaround in Caffe (index management) or cuDNN,
// use Caffe layer to max pooling
// CuDNN assumes layers are not being modified in place, thus breaking
// our index tracking for updates in some cases in Caffe. Until there
// is a workaround in Caffe (index management) or cuDNN, use Caffe
// layer to max pooling, or don't use in place layers after max
// pooling layers
if (param.pooling_param().pool() == PoolingParameter_PoolMethod_MAX) {
return shared_ptr<Layer<Dtype> >(new PoolingLayer<Dtype>(param));
} else {
Expand Down