Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we be asserting in atomic/barrier/latch/semaphore` #959

Open
brycelelbach opened this issue Dec 14, 2020 · 1 comment
Open

Should we be asserting in atomic/barrier/latch/semaphore` #959

brycelelbach opened this issue Dec 14, 2020 · 1 comment
Assignees
Labels
libcu++ For all items related to libcu++

Comments

@brycelelbach
Copy link
Collaborator

The only places in libc++ that seem to assert are places where we have added asserts - the CUDA backend for atomic, upstream barrier, latch, and semaphore. Should we really be using assert in Standard Library code?

@jrhemstad jrhemstad added the libcu++ For all items related to libcu++ label Feb 22, 2023
@miscco
Copy link
Collaborator

miscco commented Feb 23, 2023

In NVIDIA/libcudacxx#372 I am reworking this to use _LIBCUDACXX_ASSERT which should be opt in and easier to disable

@jarmak-nv jarmak-nv transferred this issue from NVIDIA/libcudacxx Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libcu++ For all items related to libcu++
Projects
Status: No status
Development

No branches or pull requests

4 participants