This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Improve handling of internal headers and modularization #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
rework_includes
branch
from
b5ec87a to
3383def
Compare
miscco
force-pushed
the
modularize_functional
branch
from
af633bb to
bd8eee2
Compare
miscco
force-pushed
the
rework_includes
branch
from
3383def to
b801047
Compare
miscco
force-pushed
the
rework_includes
branch
7 times, most recently
from
c6b6b7d to
5ae45e2
Compare
This fixes Unexpected types for some climits constants under __CUDACC_RTC__ #281
This follows libc++ and also avoids issues with the old header `__tuple`
clang-15 thankfully changed the way it reports failed static assertions it moved from "static_assert failed" to "static assertion failed" 🤦
wmaxey
approved these changes
Mar 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our
cuda/std/meowheaders are not independently usable.This means that it is not always clear, how to handle internal includes in our libc++ headers as we potentially need some other dependency.
To alleviate this move all the custom header includes / definitions into the libc++ headers, so that everything inside
cuda/std/meowis only a forward tocuda/std/detail/libcxx/meowWhile we are at it the final commit revive our internal libc++ test suite as that as been broken recently
@griwes mentioned that we should move the cuda internal definitions somewhere else, but I fear that this would be a potentially breaking change, even if it is an undocumented feature.
These changes already showed a lot of reliance on transitive includes inside our own test suite