-
Notifications
You must be signed in to change notification settings - Fork 300
Backport to 2.8: Deprecate thrust::async (#3324) #3388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to 2.8: Deprecate thrust::async (#3324) #3388
Conversation
🟨 CI finished in 1h 30m: Pass: 97%/96 | Total: 18h 46m | Avg: 11m 44s | Max: 48m 18s | Hits: 417%/12392
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 96)
| # | Runner |
|---|---|
| 71 | linux-amd64-cpu16 |
| 11 | linux-amd64-gpu-v100-latest-1 |
| 9 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1-testing |
| _CCCL_SUPPRESS_DEPRECATED_PUSH | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am missing the _CCCL_SUPRESS_DEPRECATEED_POP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, I omitted it on purpose to suppress warnings in the cudafe1.c file. But I should have added a comment about it.
Can we still go ahead, given this is the backport PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good to go ahead. It's only a test source file.
🟩 CI finished in 1h 18m: Pass: 100%/96 | Total: 18h 05m | Avg: 11m 18s | Max: 39m 19s | Hits: 417%/12392
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 96)
| # | Runner |
|---|---|
| 71 | linux-amd64-cpu16 |
| 11 | linux-amd64-gpu-v100-latest-1 |
| 9 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1-testing |
b61a97d to
d9a8c54
Compare
🟩 CI finished in 1h 25m: Pass: 100%/96 | Total: 16h 25m | Avg: 10m 15s | Max: 43m 53s | Hits: 424%/12392
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 96)
| # | Runner |
|---|---|
| 71 | linux-amd64-cpu16 |
| 11 | linux-amd64-gpu-v100-latest-1 |
| 9 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1-testing |
| _CCCL_SUPPRESS_DEPRECATED_PUSH | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good to go ahead. It's only a test source file.
No description provided.