Skip to content

Assert offset type in DispatchScan[ByKey] to be unsigned and at least 4 bytes #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Assert offset type in DispatchScan[ByKey] to be unsigned and at least 4 bytes #3992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b399c4f
Assert offset type in DispatchScan[ByKey] to be unsigned
bernhardmgruber Mar 3, 2025
005411b
Apply feedback from elstehle
bernhardmgruber Mar 4, 2025
c086566
Fix header
bernhardmgruber Mar 4, 2025
e5bdd93
check
bernhardmgruber Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cub/benchmarks/bench/scan/exclusive/by_key.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
*
******************************************************************************/

#include <cub/detail/choose_offset.cuh>
#include <cub/device/device_scan.cuh>

#include <look_back_helper.cuh>
Expand Down Expand Up @@ -82,7 +83,7 @@ static void scan(nvbench::state& state, nvbench::type_list<KeyT, ValueT, OffsetT
using val_input_it_t = const ValueT*;
using val_output_it_t = ValueT*;
using equality_op_t = ::cuda::std::equal_to<>;
using offset_t = OffsetT;
using offset_t = cub::detail::choose_offset_t<OffsetT>;

#if !TUNE_BASE
using policy_t = policy_hub_t;
Expand Down
3 changes: 3 additions & 0 deletions cub/cub/device/dispatch/dispatch_scan.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ template <
typename KernelLauncherFactory = detail::TripleChevronFactory>
struct DispatchScan
{
static_assert(::cuda::std::is_unsigned_v<OffsetT> && sizeof(OffsetT) >= 4,
"DispatchScan only supports unsigned offset types of at least 4-bytes");

//---------------------------------------------------------------------
// Constants and Types
//---------------------------------------------------------------------
Expand Down
3 changes: 3 additions & 0 deletions cub/cub/device/dispatch/dispatch_scan_by_key.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ template <
detail::scan_by_key::policy_hub<KeysInputIteratorT, AccumT, cub::detail::it_value_t<ValuesInputIteratorT>, ScanOpT>>
struct DispatchScanByKey
{
static_assert(::cuda::std::is_unsigned_v<OffsetT> && sizeof(OffsetT) >= 4,
"DispatchScan only supports unsigned offset types of at least 4-bytes");

//---------------------------------------------------------------------
// Constants and Types
//---------------------------------------------------------------------
Expand Down
Loading