Skip to content

Extend cub::FutureValue #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernhardmgruber merged 4 commits into from
Mar 11, 2025
Merged

Extend cub::FutureValue #4075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
522b229
Extend cub::FutureValue
bernhardmgruber Mar 10, 2025
231bea9
Apply suggestions from code review
bernhardmgruber Mar 10, 2025
50ac8e0
Drop write-access
bernhardmgruber Mar 11, 2025
e32cc2e
Update cub/cub/util_type.cuh
bernhardmgruber Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cub/cub/util_type.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,12 @@ struct FutureValue
{
using value_type = T;
using iterator_type = IterT;

explicit _CCCL_HOST_DEVICE _CCCL_FORCEINLINE FutureValue(IterT iter)
: m_iter(iter)
{}
_CCCL_HOST_DEVICE _CCCL_FORCEINLINE operator T()

_CCCL_HOST_DEVICE _CCCL_FORCEINLINE operator T() const noexcept
{
return *m_iter;
}
Expand All @@ -274,6 +276,9 @@ private:
IterT m_iter;
};

template <typename IterT>
FutureValue(IterT) -> FutureValue<detail::it_value_t<IterT>, IterT>;

namespace detail
{

Expand Down
20 changes: 20 additions & 0 deletions cub/test/catch2_test_util_type.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,23 @@ C2H_TEST("Test CustomHalf", "[util][type]")
CHECK(cuda::std::numeric_limits<half_t>::max() == half_t::max());
CHECK(cuda::std::numeric_limits<half_t>::lowest() == half_t::lowest());
}

C2H_TEST("Test FutureValue", "[util][type]")
{
// read
int value;
cub::FutureValue<int> fv{&value};
value = 42;
CHECK(fv == 42);
value = 43;
CHECK(fv == 43);

// CTAD
cub::FutureValue fv2{&value};
STATIC_REQUIRE(::cuda::std::is_same_v<decltype(fv2), cub::FutureValue<int, int*>>);

c2h::device_vector<int> v(0);
cub::FutureValue fv3{v.begin()};
STATIC_REQUIRE(
::cuda::std::is_same_v<decltype(fv3), cub::FutureValue<int, typename c2h::device_vector<int>::iterator>>);
}
Loading