-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host-bulk for_each
for static_map
#565
Conversation
/ok to test |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the missing deallocate(tmp)
With the first overload no longer desired by libcudf, shall we remove it from the current PR? |
@PointKernel the first overload was requested (or better proposed by me) in this thread (NV internal): https://nvidia.enterprise.slack.com/archives/CRJDZ0SKG/p1721975163922999 I think this overload is useful in general as it enables functionality similar to the |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
This PR adds two overloads of host-bulk
for_each
API for static_map.for_each(Callback callback_op)
executes callback_op on every filled element in the map.
for_each(InputIt first, IntputIt last, CallbackOp callback_op)
executes callback_op on every matched slot with key equals to a key from the input sequence.