Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Remove extra % character and some unused variables #349

Conversation

gevtushenko
Copy link
Collaborator

I've noticed confusing SM number queries in algorithms that shouldn't use it. So I decided to combine this refactoring with the removal of %Device comments that we've discussed. This PR has the lowest possible priority.

@gevtushenko gevtushenko added the only: docs Documentation changes only. Doesn't need code CI. label Jul 17, 2021
@alliepiper alliepiper added P2: nice to have Desired, but not necessary. and removed only: docs Documentation changes only. Doesn't need code CI. labels Jul 19, 2021
@alliepiper alliepiper added this to the 1.14.0 milestone Jul 19, 2021
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- go ahead and start testing on this one.

(I removed the only: docs tag, since this does have code changes. That tag is for pure doc changes that don't require testing.)

@alliepiper
Copy link
Collaborator

I just came across this in the Doxygen FAQ:

Q: Doxygen automatically generates a link to the class MyClass somewhere in the running text. How do I prevent that at a certain place?
A: Put a % in front of the class name. Like this: %MyClass. Doxygen will then remove the % and keep the word unlinked.

I don't see how this would apply here, since we don't have anything just named "Device". Maybe there used to be?

Either way, we should keep an eye on this once we have the new docs site up.

@alliepiper alliepiper modified the milestones: 1.14.0, 1.15.0 Aug 17, 2021
@gevtushenko gevtushenko force-pushed the main-refactoring/github/fix_comments_and_unused_variables branch from db01ae8 to d6ba3cf Compare August 26, 2021 20:38
@gevtushenko gevtushenko added testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Aug 26, 2021
@alliepiper
Copy link
Collaborator

@senior-zero Since this is so close to being ready, let's get it into 1.15. Can you check on the DVS results for this and merge if all is well?

@gevtushenko gevtushenko added testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Oct 15, 2021
@gevtushenko gevtushenko merged commit 703b10a into NVIDIA:main Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2: nice to have Desired, but not necessary. testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants