Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuda-python 11.8.5/12.6.2 package content issues #226

Closed
leofang opened this issue Nov 8, 2024 · 2 comments · Fixed by #230 or #231
Closed

cuda-python 11.8.5/12.6.2 package content issues #226

leofang opened this issue Nov 8, 2024 · 2 comments · Fixed by #230 or #231
Labels
bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! packaging Anything related to wheels or Conda packages
Milestone
cuda-python 12.6....

Comments

@leofang
Copy link
Member

leofang commented Nov 8, 2024 •
edited
Loading

Summarizing an offline issue raised by @vyasr since it is quite complicated. When building from the current main branch (commit 72acaaf), locally I observed:

  • building sdist -> cuda/ccudart.pxd & co are there
  • building wheel (directly or through sdist) -> .pxd/.pyx are not there

Unfortunately this has impacted the released wheels too:

  1. Top-level .pxd/.pyx files missing (ex: cuda/ccudart.pxd & co)
  2. A extra bindings module is installed to site-packages
    • ex: cuda_python-12.6.2-cp312-cp312-win_amd64.whl

(I only did a quick random checks, not systematic.)

I believe another hot fix is unfortunately needed in order for us to also fix wheels (if only conda packages were impacted, we could've just included the patch and rebuilt with a higher build number).
@leofang leofang added bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! packaging Anything related to wheels or Conda packages labels Nov 8, 2024
This was referenced Nov 8, 2024
Closed
Closed
This was referenced Nov 9, 2024
Merged
Merged
@leofang leofang linked a pull request Nov 9, 2024 that will close this issue
Fix discovery for trampoline files #231
Merged
@leofang leofang modified the milestones: cuda-python 12-next, 11-next, cuda-python 12.6.3 & 11.8.6 Nov 9, 2024
@leofang leofang modified the milestones: cuda-python 12.6.3 & 11.8.6, cuda-python 12.6.2 & 11.8.5 Nov 13, 2024
@leofang
Copy link
Member Author

leofang commented Nov 13, 2024 •
edited
Loading

Resolution: Since this is a packaging only issue, we rebuilt all the packages:

yanked the old 12.6.2/11.8.5 wheels:

and marked the conda-forge packages as broken:

@leofang leofang mentioned this issue Nov 13, 2024
Closed
@leofang
Copy link
Member Author

leofang commented Nov 13, 2024

Packaging issue explained: https://github.com/NVIDIA/cuda-python/pull/230/files#r1839408967

This was referenced Nov 13, 2024
Merged
Closed
This was referenced Nov 14, 2024
Merged
Merged
This was referenced Dec 4, 2024
Merged
Closed
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue Dec 4, 2024
@bdice
Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 (#4798)
22a32c1 
Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #4798
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Dec 4, 2024
@bdice
Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 (#17326)
6440207 
Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #17326
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Dec 5, 2024
@bdice
Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 (#2517)
3ce5b6a 
Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #2517
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this issue Dec 5, 2024
@bdice
Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 (#508)
69199c2 
Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #508
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue Dec 5, 2024
@bdice
Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 (#564)
a284f55 
Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #564
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this issue Dec 5, 2024
@bdice
Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 (#1729)
00287e0 
Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #1729
@vyasr vyasr mentioned this issue Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! packaging Anything related to wheels or Conda packages
Projects
None yet
Milestone
cuda-python 12.6.2 & 11.8.5
1 participant
@leofang