-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the build portion of the gh-actions #249
Conversation
/ok to test |
/ok to test |
@sandeepd-nv I cherry picked your commits to remove the dead code, and address the formatting change. Per the gh-runners slack channel, there is currently an issue which is causing actions nvidia-wide to hang. edit: runners are fixed |
/ok to test |
/ok to test |
Wow the setup is pretty sophisticated. Looks good to me as a meaningful step forward, although I'm not familiar with the details. One high-level question, maybe for another PR: Could the build be organized so that building cuda.bindings and cuda.core appear as two separate steps in the build log? The idea is to make it very obvious in the log what step completed successfully, e.g. > Build cuda.bindings Where the > are the clickable arrows in the log, for expanding or un-expanding each part of the log. |
@rwgk yeah.. It took me awhile to wrap my head around the flow of logic. My plan was to make as few changes as possible just to get a build and test working. Then create some gh-issues to track improvements like splitting the bindings and core + builds and tests. It would be simple to do it naively, but to do it in an efficient way (minimizing container and conda spin-ups) would take some degree of thought/effort. I just want to have some automated testing ASAP. What are your thoughts on that approach? ref: #249 |
Working incrementally sounds good. I just looked at the latest "raw" build log here, below is a small section. I wonder, what happens if you simply add (I think the timestamps are automatic.)
|
/ok to test |
I will look into that. Sounds like it could be the perfect easy solution @rwgk |
/ok to test |
As a first review, this will: