Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster to LaunchConfig to support thread block clusters on Hopper #261

Merged
merged 13 commits into from
Dec 13, 2024
Merged

Add cluster to LaunchConfig to support thread block clusters on Hopper #261

merged 13 commits into from
Dec 13, 2024

Conversation

leofang
Copy link
Member

@leofang leofang commented Dec 3, 2024

Close #204.

@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.core Everything related to the cuda.core module labels Dec 3, 2024
@leofang leofang added this to the cuda.core beta 2 milestone Dec 3, 2024
@leofang leofang requested a review from vzhurba01 December 3, 2024 05:18
@leofang leofang self-assigned this Dec 3, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Dec 3, 2024 •
edited
Loading

(Merge after #247; only commits starting 5d253f1 are new.)

@leofang leofang marked this pull request as ready for review December 4, 2024 03:23
@leofang leofang mentioned this pull request Dec 4, 2024
Merged
@leofang leofang mentioned this pull request Dec 8, 2024
Merged
@leofang
Copy link
Member Author

leofang commented Dec 8, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 8, 2024

@vzhurba01 this is ready for review

ksimpson-work
ksimpson-work reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ksimpson-work ksimpson-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit / comment about the documentation, but otherwise lgtm

@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

@ksimpson-work could you help make the changes and get this merged? 🙂

vzhurba01
vzhurba01 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@vzhurba01 vzhurba01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksimpson-work
Copy link
Contributor

/ok to test

@ksimpson-work
Copy link
Contributor

running the tests again for good practice, although the recent commits were only comment changes

@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

All green, let's merge. Thanks @ksimpson-work @vzhurba01!

@leofang leofang merged commit 4ad4042 into NVIDIA:main Dec 13, 2024
30 checks passed
@leofang leofang deleted the cluster branch December 13, 2024 19:39
@leofang leofang mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimpson-work ksimpson-work ksimpson-work left review comments

@vzhurba01 vzhurba01 vzhurba01 approved these changes

Assignees

@leofang leofang

@ksimpson-work ksimpson-work

Labels
cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P1 Medium priority - Should do
Projects
None yet
Milestone
cuda.core beta 2
Development

Successfully merging this pull request may close these issues.

Support launching thread block clusters
3 participants
@leofang @ksimpson-work @vzhurba01