Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for wheel release + populate PyPI page information #296

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Prepare for wheel release + populate PyPI page information #296

merged 5 commits into from
Dec 13, 2024

Conversation

leofang
Copy link
Member

@leofang leofang commented Dec 13, 2024 •
edited
Loading

Close #147.

@leofang leofang added P0 High priority - Must do! packaging Anything related to wheels or Conda packages cuda.core Everything related to the cuda.core module labels Dec 13, 2024
@leofang leofang added this to the cuda.core beta 2 milestone Dec 13, 2024
@leofang leofang self-assigned this Dec 13, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

/ok to test

1 similar comment
@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

/ok to test

@leofang leofang changed the title WIP: Populate PyPI page information Populate PyPI page information Dec 13, 2024
@leofang leofang changed the title Populate PyPI page information Prepare for wheel release + populate PyPI page information Dec 13, 2024
@leofang leofang marked this pull request as ready for review December 13, 2024 14:39
@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

/ok to test

@leofang leofang requested a review from aterrel December 13, 2024 18:52
vzhurba01
vzhurba01 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@vzhurba01 vzhurba01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I do have a general comment. By having both DESCRIPTION.rst and README.md I feel like we're duplicating some similar documentation and requires us to remember to update both.

I see that the rst version is a simplified to be better suited for a wheel distribution, so I'm ok with this. Just noticing this made me hesitate for a second and I wanted it to be noted.

@leofang
Copy link
Member Author

leofang commented Dec 13, 2024

Thanks, Vlad. Indeed we're duplicating some of the information. It might take a few iterations to consolidate the two files and have something presentable on both PyPI and GitHub. Let's address this in the next release.

@leofang leofang mentioned this pull request Dec 13, 2024
Open
@leofang leofang merged commit dde2fe2 into NVIDIA:main Dec 13, 2024
30 checks passed
@leofang leofang deleted the wheel_prep branch December 13, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhurba01 vzhurba01 vzhurba01 approved these changes

@ksimpson-work ksimpson-work Awaiting requested review from ksimpson-work

@aterrel aterrel Awaiting requested review from aterrel

Assignees

@leofang leofang

Labels
cuda.core Everything related to the cuda.core module P0 High priority - Must do! packaging Anything related to wheels or Conda packages
Projects
None yet
Milestone
cuda.core beta 2
Development

Successfully merging this pull request may close these issues.

Publish standalone cuda-core packages
2 participants
@leofang @vzhurba01