Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuda.core v0.1.1 final doc touch #301

Merged
merged 11 commits into from
Dec 20, 2024
Merged

cuda.core v0.1.1 final doc touch #301

merged 11 commits into from
Dec 20, 2024

Conversation

leofang
Copy link
Member

@leofang leofang commented Dec 13, 2024

No description provided.

@leofang leofang added this to the cuda.core beta 2 milestone Dec 13, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Dec 13, 2024
@leofang leofang self-assigned this Dec 13, 2024
@leofang leofang marked this pull request as ready for review December 20, 2024 18:11
@leofang leofang marked this pull request as draft December 20, 2024 18:12
@leofang leofang marked this pull request as ready for review December 20, 2024 18:13
@leofang
Copy link
Member Author

leofang commented Dec 20, 2024

@ksimpson-work @jollylili let's merge this and rebuild the docs

jollylili
jollylili previously approved these changes Dec 20, 2024
View reviewed changes
ksimpson-work
ksimpson-work previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ksimpson-work ksimpson-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple nits but feel free to ignore if you disagree

cuda_core/docs/source/release/0.1.1-notes.md Show resolved Hide resolved
cuda_core/docs/source/release/0.1.1-notes.md Outdated Show resolved Hide resolved
@leofang leofang dismissed stale reviews from ksimpson-work and jollylili via 3641e27 December 20, 2024 18:55
@leofang leofang mentioned this pull request Dec 20, 2024
Merged
@ksimpson-work ksimpson-work merged commit 4135a2f into NVIDIA:main Dec 20, 2024
@leofang leofang deleted the doc_nits branch December 20, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimpson-work ksimpson-work ksimpson-work approved these changes

@jollylili jollylili jollylili left review comments

Assignees

@leofang leofang

Labels
cuda.core Everything related to the cuda.core module documentation Improvements or additions to documentation P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 2
Development

Successfully merging this pull request may close these issues.
3 participants
@leofang @jollylili @ksimpson-work