Skip to content

Update benchmarks and enable them #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

vzhurba01
Copy link
Collaborator

Close #109

@vzhurba01 vzhurba01 added bug Something isn't working P2 Low priority - Nice to have cuda.bindings Everything related to the cuda.bindings module labels Jan 16, 2025
@vzhurba01 vzhurba01 added this to the cuda-bindings parking lot milestone Jan 16, 2025
@vzhurba01 vzhurba01 self-assigned this Jan 16, 2025
Copy link
Contributor

copy-pr-bot bot commented Jan 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01
Copy link
Collaborator Author

/ok to test

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for delay.

As a follow-up we should work out a nightly test plan so that we can run the benchmarks there (#29).

@@ -25,7 +25,7 @@ def ASSERT_DRV(err):
raise RuntimeError(f"Unknown error type: {err}")


@pytest.fixture
@pytest.fixture(scope="function")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: isn't function already the default? Actually this is interesting because with cuInit I'd assume that this is session-scoped since there's no way to de-init.

@leofang
Copy link
Member

leofang commented Feb 19, 2025

/ok to test

@leofang leofang enabled auto-merge February 19, 2025 22:02
@leofang
Copy link
Member

leofang commented Feb 21, 2025

/ok to test

This comment has been minimized.

@leofang leofang merged commit 02a4178 into NVIDIA:main Feb 21, 2025
73 checks passed
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P2 Low priority - Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CuPy benchmark is unconditionally skipped
2 participants