-
Notifications
You must be signed in to change notification settings - Fork 182
Update benchmarks and enable them #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for delay.
As a follow-up we should work out a nightly test plan so that we can run the benchmarks there (#29).
@@ -25,7 +25,7 @@ def ASSERT_DRV(err): | |||
raise RuntimeError(f"Unknown error type: {err}") | |||
|
|||
|
|||
@pytest.fixture | |||
@pytest.fixture(scope="function") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: isn't function already the default? Actually this is interesting because with cuInit
I'd assume that this is session-scoped since there's no way to de-init.
/ok to test |
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
Close #109